Mathias STRASSER
b7dc27f2a5
Les enseignants ont besoin de moyennes à jour immédiatement après la publication ou modification des notes, sans attendre un batch nocturne. Le système recalcule via Domain Events synchrones : statistiques d'évaluation (min/max/moyenne/médiane), moyennes matières pondérées (normalisation /20), et moyenne générale par élève. Les résultats sont stockés dans des tables dénormalisées avec cache Redis (TTL 5 min). Trois endpoints API exposent les données avec contrôle d'accès par rôle. Une commande console permet le backfill des données historiques au déploiement.
103 lines
2.5 KiB
Markdown
103 lines
2.5 KiB
Markdown
---
|
|
name: 'step-03c-subagent-maintainability'
|
|
description: 'Subagent: Check test maintainability (readability, structure, DRY)'
|
|
subagent: true
|
|
outputFile: '/tmp/tea-test-review-maintainability-{{timestamp}}.json'
|
|
---
|
|
|
|
# Subagent 3C: Maintainability Quality Check
|
|
|
|
## SUBAGENT CONTEXT
|
|
|
|
This is an **isolated subagent** running in parallel with other quality dimension checks.
|
|
|
|
**Your task:** Analyze test files for MAINTAINABILITY violations only.
|
|
|
|
---
|
|
|
|
## MANDATORY EXECUTION RULES
|
|
|
|
- ✅ Check MAINTAINABILITY only (not other quality dimensions)
|
|
- ✅ Output structured JSON to temp file
|
|
- ❌ Do NOT check determinism, isolation, coverage, or performance
|
|
|
|
---
|
|
|
|
## SUBAGENT TASK
|
|
|
|
### 1. Identify Maintainability Violations
|
|
|
|
**HIGH SEVERITY Violations**:
|
|
|
|
- Tests >100 lines (too complex)
|
|
- No test.describe grouping
|
|
- Duplicate test logic (copy-paste)
|
|
- Unclear test names (no Given/When/Then structure)
|
|
- Magic numbers/strings without constants
|
|
|
|
**MEDIUM SEVERITY Violations**:
|
|
|
|
- Tests missing comments for complex logic
|
|
- Inconsistent naming conventions
|
|
- Excessive nesting (>3 levels)
|
|
- Large setup/teardown blocks
|
|
|
|
**LOW SEVERITY Violations**:
|
|
|
|
- Minor code style issues
|
|
- Could benefit from helper functions
|
|
- Inconsistent assertion styles
|
|
|
|
### 2. Calculate Maintainability Score
|
|
|
|
```javascript
|
|
const severityWeights = { HIGH: 10, MEDIUM: 5, LOW: 2 };
|
|
const totalPenalty = violations.reduce((sum, v) => sum + severityWeights[v.severity], 0);
|
|
const score = Math.max(0, 100 - totalPenalty);
|
|
```
|
|
|
|
---
|
|
|
|
## OUTPUT FORMAT
|
|
|
|
```json
|
|
{
|
|
"dimension": "maintainability",
|
|
"score": 75,
|
|
"max_score": 100,
|
|
"grade": "C",
|
|
"violations": [
|
|
{
|
|
"file": "tests/e2e/complex-flow.spec.ts",
|
|
"line": 1,
|
|
"severity": "HIGH",
|
|
"category": "test-too-long",
|
|
"description": "Test file is 250 lines - too complex to maintain",
|
|
"suggestion": "Split into multiple smaller test files by feature area",
|
|
"code_snippet": "test.describe('Complex flow', () => { /* 250 lines */ });"
|
|
}
|
|
],
|
|
"passed_checks": 10,
|
|
"failed_checks": 5,
|
|
"violation_summary": {
|
|
"HIGH": 2,
|
|
"MEDIUM": 2,
|
|
"LOW": 1
|
|
},
|
|
"recommendations": [
|
|
"Split large test files into smaller, focused files (<100 lines each)",
|
|
"Add test.describe grouping for related tests",
|
|
"Extract duplicate logic into helper functions"
|
|
],
|
|
"summary": "Tests have maintainability issues - 5 violations (2 HIGH)"
|
|
}
|
|
```
|
|
|
|
---
|
|
|
|
## EXIT CONDITION
|
|
|
|
Subagent completes when JSON output written to temp file.
|
|
|
|
**Subagent terminates here.**
|