Mathias STRASSER
b7dc27f2a5
Les enseignants ont besoin de moyennes à jour immédiatement après la publication ou modification des notes, sans attendre un batch nocturne. Le système recalcule via Domain Events synchrones : statistiques d'évaluation (min/max/moyenne/médiane), moyennes matières pondérées (normalisation /20), et moyenne générale par élève. Les résultats sont stockés dans des tables dénormalisées avec cache Redis (TTL 5 min). Trois endpoints API exposent les données avec contrôle d'accès par rôle. Une commande console permet le backfill des données historiques au déploiement.
126 lines
3.1 KiB
Markdown
126 lines
3.1 KiB
Markdown
---
|
|
name: 'step-03b-subagent-isolation'
|
|
description: 'Subagent: Check test isolation (no shared state/dependencies)'
|
|
subagent: true
|
|
outputFile: '/tmp/tea-test-review-isolation-{{timestamp}}.json'
|
|
---
|
|
|
|
# Subagent 3B: Isolation Quality Check
|
|
|
|
## SUBAGENT CONTEXT
|
|
|
|
This is an **isolated subagent** running in parallel with other quality dimension checks.
|
|
|
|
**Your task:** Analyze test files for ISOLATION violations only.
|
|
|
|
---
|
|
|
|
## MANDATORY EXECUTION RULES
|
|
|
|
- ✅ Check ISOLATION only (not other quality dimensions)
|
|
- ✅ Output structured JSON to temp file
|
|
- ❌ Do NOT check determinism, maintainability, coverage, or performance
|
|
- ❌ Do NOT modify test files (read-only analysis)
|
|
|
|
---
|
|
|
|
## SUBAGENT TASK
|
|
|
|
### 1. Identify Isolation Violations
|
|
|
|
**Scan test files for isolation issues:**
|
|
|
|
**HIGH SEVERITY Violations**:
|
|
|
|
- Global state mutations (global variables modified)
|
|
- Test order dependencies (test B depends on test A running first)
|
|
- Shared database records without cleanup
|
|
- beforeAll/afterAll with side effects leaking to other tests
|
|
|
|
**MEDIUM SEVERITY Violations**:
|
|
|
|
- Missing test cleanup (created data not deleted)
|
|
- Shared fixtures that mutate state
|
|
- Tests that assume specific execution order
|
|
- Environment variables modified without restoration
|
|
|
|
**LOW SEVERITY Violations**:
|
|
|
|
- Tests sharing test data (but not mutating)
|
|
- Missing test.describe grouping
|
|
- Tests that could be more isolated
|
|
|
|
### 2. Calculate Isolation Score
|
|
|
|
```javascript
|
|
const totalChecks = testFiles.length * checksPerFile;
|
|
const failedChecks = violations.length;
|
|
const severityWeights = { HIGH: 10, MEDIUM: 5, LOW: 2 };
|
|
const totalPenalty = violations.reduce((sum, v) => sum + severityWeights[v.severity], 0);
|
|
const score = Math.max(0, 100 - totalPenalty);
|
|
```
|
|
|
|
---
|
|
|
|
## OUTPUT FORMAT
|
|
|
|
```json
|
|
{
|
|
"dimension": "isolation",
|
|
"score": 90,
|
|
"max_score": 100,
|
|
"grade": "A-",
|
|
"violations": [
|
|
{
|
|
"file": "tests/api/integration.spec.ts",
|
|
"line": 15,
|
|
"severity": "HIGH",
|
|
"category": "test-order-dependency",
|
|
"description": "Test depends on previous test creating user record",
|
|
"suggestion": "Each test should create its own test data in beforeEach",
|
|
"code_snippet": "test('should update user', async () => { /* assumes user exists */ });"
|
|
}
|
|
],
|
|
"passed_checks": 14,
|
|
"failed_checks": 1,
|
|
"total_checks": 15,
|
|
"violation_summary": {
|
|
"HIGH": 1,
|
|
"MEDIUM": 0,
|
|
"LOW": 0
|
|
},
|
|
"recommendations": [
|
|
"Add beforeEach hooks to create test data",
|
|
"Add afterEach hooks to cleanup created records",
|
|
"Use test.describe.configure({ mode: 'parallel' }) to enforce isolation"
|
|
],
|
|
"summary": "Tests are well isolated with 1 HIGH severity violation"
|
|
}
|
|
```
|
|
|
|
---
|
|
|
|
## EXIT CONDITION
|
|
|
|
Subagent completes when:
|
|
|
|
- ✅ All test files analyzed for isolation violations
|
|
- ✅ Score calculated
|
|
- ✅ JSON output written to temp file
|
|
|
|
**Subagent terminates here.**
|
|
|
|
---
|
|
|
|
## 🚨 SUBAGENT SUCCESS METRICS
|
|
|
|
### ✅ SUCCESS:
|
|
|
|
- Only isolation checked (not other dimensions)
|
|
- JSON output valid and complete
|
|
|
|
### ❌ FAILURE:
|
|
|
|
- Checked quality dimensions other than isolation
|
|
- Invalid or missing JSON output
|