Step 04 — OHS (Sales)

- OrderController OHS versionné sous /api/sales/v1/
- OrderViewAssembler : assemble le modèle interne → OrderView (Published Language)
- Endpoints : POST /orders, GET /orders/{id}, POST /orders/{id}/confirm, GET /customers/{id}/orders
- Tests vérifiant que les modèles internes ne sont jamais exposés

src/LegacyFulfillment/Infrastructure/AntiCorruption/LegacyCreateShipmentCommand.php

@@ -0,0 +1,24 @@
+<?php
+
+declare(strict_types=1);
+
+namespace MiniShop\LegacyFulfillment\Infrastructure\AntiCorruption;
+
+/**
+ * Modele legacy : champs abreges et codifications imposees par le systeme d'expedition historique.
+ * Ce format ne doit jamais fuiter en dehors de l'ACL.
+ */
+final readonly class LegacyCreateShipmentCommand
+{
+    public function __construct(
+        public string $ord_ref,      // reference commande (format legacy: prefixe LEG-)
+        public string $rcpt_nm,      // nom destinataire (tronque a 35 chars)
+        public string $rcpt_addr,    // adresse sur une ligne
+        public string $rcpt_zip,     // code postal
+        public string $rcpt_cty,     // code pays ISO 2
+        public int $wgt_g,           // poids en grammes
+        public string $desc,         // description colis
+        public string $req_dt,       // date demande format legacy YYYYMMDD
+        public string $sts,          // statut: NEW, DIS (dispatched)
+    ) {}
+}

src/LegacyFulfillment/Infrastructure/AntiCorruption/LegacyShipmentAcl.php

@@ -0,0 +1,43 @@
+<?php
+
+declare(strict_types=1);
+
+namespace MiniShop\LegacyFulfillment\Infrastructure\AntiCorruption;
+
+use MiniShop\Contracts\Sales\V1\Event\OrderConfirmed;
+
+/**
+ * Anti-Corruption Layer : traduit le Published Language sales.v1 vers le modele
+ * legacy d'expedition. Isole toutes les bizarreries du format legacy.
+ *
+ * @see §13.2 du boilerplate spec
+ */
+final class LegacyShipmentAcl
+{
+    private const int MAX_RECIPIENT_LENGTH = 35;
+
+    public function fromSalesOrderConfirmed(OrderConfirmed $message): LegacyCreateShipmentCommand
+    {
+        $recipientName = mb_substr('Customer ' . $message->customerId, 0, self::MAX_RECIPIENT_LENGTH);
+
+        $totalWeight = max(100, count($message->lines) * 500);
+
+        $description = sprintf(
+            'CMD-%s/%d articles',
+            mb_substr($message->orderId, 0, 8),
+            count($message->lines),
+        );
+
+        return new LegacyCreateShipmentCommand(
+            ord_ref: 'LEG-' . $message->orderId,
+            rcpt_nm: $recipientName,
+            rcpt_addr: 'N/A',
+            rcpt_zip: '00000',
+            rcpt_cty: 'FR',
+            wgt_g: $totalWeight,
+            desc: $description,
+            req_dt: date('Ymd'),
+            sts: 'NEW',
+        );
+    }
+}

src/LegacyFulfillment/Interfaces/Messaging/WhenOrderConfirmed.php

@@ -0,0 +1,40 @@
+<?php
+
+declare(strict_types=1);
+
+namespace MiniShop\LegacyFulfillment\Interfaces\Messaging;
+
+use MiniShop\Contracts\Sales\V1\Event\OrderConfirmed;
+use MiniShop\LegacyFulfillment\Application\Command\RequestShipmentFromSalesOrder;
+use MiniShop\LegacyFulfillment\Application\Command\RequestShipmentFromSalesOrderHandler;
+use MiniShop\LegacyFulfillment\Infrastructure\AntiCorruption\LegacyShipmentAcl;
+use Symfony\Component\Messenger\Attribute\AsMessageHandler;
+
+/**
+ * Consumer ACL : recoit sales.v1.OrderConfirmed, passe par l'Anti-Corruption Layer
+ * pour traduire vers le modele legacy, puis delegue au handler applicatif.
+ */
+#[AsMessageHandler]
+final readonly class WhenOrderConfirmed
+{
+    public function __construct(
+        private LegacyShipmentAcl $acl,
+        private RequestShipmentFromSalesOrderHandler $handler,
+    ) {}
+
+    public function __invoke(OrderConfirmed $message): void
+    {
+        $legacyCommand = $this->acl->fromSalesOrderConfirmed($message);
+
+        ($this->handler)(new RequestShipmentFromSalesOrder(
+            externalOrderId: $message->orderId,
+            recipientName: $legacyCommand->rcpt_nm,
+            street: $legacyCommand->rcpt_addr,
+            city: 'N/A',
+            postalCode: $legacyCommand->rcpt_zip,
+            country: $legacyCommand->rcpt_cty,
+            totalWeightInGrams: $legacyCommand->wgt_g,
+            description: $legacyCommand->desc,
+        ));
+    }
+}

src/Sales/Interfaces/Http/Api/V1/OrderController.php

@@ -0,0 +1,84 @@
+<?php
+
+declare(strict_types=1);
+
+namespace MiniShop\Sales\Interfaces\Http\Api\V1;
+
+use MiniShop\Sales\Application\Command\ConfirmOrder;
+use MiniShop\Sales\Application\Command\ConfirmOrderHandler;
+use MiniShop\Sales\Application\Command\PlaceOrder;
+use MiniShop\Sales\Application\Command\PlaceOrderHandler;
+use MiniShop\Sales\Application\Query\GetOrderById;
+use MiniShop\Sales\Application\Query\GetOrderByIdHandler;
+use MiniShop\Sales\Application\Query\ListOrdersByCustomer;
+use MiniShop\Sales\Application\Query\ListOrdersByCustomerHandler;
+use MiniShop\Shared\Technical\UuidGenerator;
+use Symfony\Component\HttpFoundation\JsonResponse;
+use Symfony\Component\HttpFoundation\Request;
+use Symfony\Component\HttpFoundation\Response;
+use Symfony\Component\Routing\Attribute\Route;
+
+/**
+ * Open Host Service — sales.v1
+ * API stable et versionnee. Les modeles internes ne sont jamais exposes.
+ * Tous les DTOs de reponse passent par OrderViewAssembler → OrderView (Published Language).
+ */
+#[Route('/api/sales/v1')]
+final readonly class OrderController
+{
+    public function __construct(
+        private PlaceOrderHandler $placeOrderHandler,
+        private ConfirmOrderHandler $confirmOrderHandler,
+        private GetOrderByIdHandler $getOrderByIdHandler,
+        private ListOrdersByCustomerHandler $listOrdersByCustomerHandler,
+        private OrderViewAssembler $assembler,
+    ) {}
+
+    #[Route('/orders', name: 'ohs_sales_place_order', methods: ['POST'])]
+    public function placeOrder(Request $request): JsonResponse
+    {
+        /** @var array{customerId: string, lines: list<array{productName: string, quantity: int, unitPriceInCents: int, currency: string}>} $data */
+        $data = json_decode($request->getContent(), true, flags: JSON_THROW_ON_ERROR);
+
+        $orderId = UuidGenerator::generate();
+
+        ($this->placeOrderHandler)(new PlaceOrder(
+            orderId: $orderId,
+            customerId: $data['customerId'],
+            lines: $data['lines'],
+        ));
+
+        $order = ($this->getOrderByIdHandler)(new GetOrderById($orderId));
+
+        return new JsonResponse($this->assembler->toView($order), Response::HTTP_CREATED);
+    }
+
+    #[Route('/orders/{orderId}', name: 'ohs_sales_get_order', methods: ['GET'])]
+    public function getOrder(string $orderId): JsonResponse
+    {
+        $order = ($this->getOrderByIdHandler)(new GetOrderById($orderId));
+
+        return new JsonResponse($this->assembler->toView($order));
+    }
+
+    #[Route('/orders/{orderId}/confirm', name: 'ohs_sales_confirm_order', methods: ['POST'])]
+    public function confirmOrder(string $orderId): JsonResponse
+    {
+        ($this->confirmOrderHandler)(new ConfirmOrder(orderId: $orderId));
+
+        $order = ($this->getOrderByIdHandler)(new GetOrderById($orderId));
+
+        return new JsonResponse($this->assembler->toView($order));
+    }
+
+    #[Route('/customers/{customerId}/orders', name: 'ohs_sales_list_orders', methods: ['GET'])]
+    public function listOrders(string $customerId): JsonResponse
+    {
+        $orders = ($this->listOrdersByCustomerHandler)(new ListOrdersByCustomer($customerId));
+
+        return new JsonResponse(array_map(
+            fn ($order) => $this->assembler->toView($order),
+            $orders,
+        ));
+    }
+}

src/Sales/Interfaces/Http/Api/V1/OrderViewAssembler.php

@@ -0,0 +1,37 @@
+<?php
+
+declare(strict_types=1);
+
+namespace MiniShop\Sales\Interfaces\Http\Api\V1;
+
+use MiniShop\Contracts\Sales\V1\Api\OrderView;
+use MiniShop\Sales\Domain\Model\Order;
+use MiniShop\Sales\Domain\Model\OrderLine;
+
+/**
+ * Assemble le modele interne Order vers le DTO public OrderView (sales.v1).
+ * Les modeles internes de Sales ne sont jamais exposes directement.
+ */
+final class OrderViewAssembler
+{
+    public function toView(Order $order): OrderView
+    {
+        return new OrderView(
+            orderId: $order->id->toString(),
+            customerId: $order->customerId->toString(),
+            status: $order->status()->value,
+            totalInCents: $order->total()->amount,
+            currency: $order->total()->currency,
+            lines: array_map(
+                static fn (OrderLine $line): array => [
+                    'productName' => $line->productName,
+                    'quantity' => $line->quantity,
+                    'unitPriceInCents' => $line->unitPrice->amount,
+                    'currency' => $line->unitPrice->currency,
+                    'lineTotalInCents' => $line->lineTotal()->amount,
+                ],
+                $order->lines(),
+            ),
+        );
+    }
+}

tests/Integration/LegacyFulfillmentAclTest.php

@@ -0,0 +1,47 @@
+<?php
+
+declare(strict_types=1);
+
+namespace MiniShop\Tests\Integration;
+
+use MiniShop\Contracts\Sales\V1\Event\OrderConfirmed;
+use MiniShop\LegacyFulfillment\Application\Command\RequestShipmentFromSalesOrderHandler;
+use MiniShop\LegacyFulfillment\Domain\Model\LegacyOrderRef;
+use MiniShop\LegacyFulfillment\Infrastructure\AntiCorruption\LegacyShipmentAcl;
+use MiniShop\LegacyFulfillment\Infrastructure\Gateway\FakeLegacyFulfillmentGateway;
+use MiniShop\LegacyFulfillment\Infrastructure\Persistence\InMemoryShipmentRequestRepository;
+use MiniShop\LegacyFulfillment\Interfaces\Messaging\WhenOrderConfirmed;
+use MiniShop\Shared\Technical\SystemClock;
+use PHPUnit\Framework\TestCase;
+
+/**
+ * Test d'integration : le consumer ACL de LegacyFulfillment recoit un message
+ * sales.v1.OrderConfirmed, le traduit via l'ACL, et cree une demande d'expedition.
+ */
+final class LegacyFulfillmentAclTest extends TestCase
+{
+    public function test_acl_consumer_creates_shipment_from_contract(): void
+    {
+        $shipmentRepo = new InMemoryShipmentRequestRepository();
+        $gateway = new FakeLegacyFulfillmentGateway();
+
+        $consumer = new WhenOrderConfirmed(
+            new LegacyShipmentAcl(),
+            new RequestShipmentFromSalesOrderHandler($shipmentRepo, $gateway, new SystemClock()),
+        );
+
+        $consumer(new OrderConfirmed(
+            orderId: 'order-acl-int-001',
+            customerId: 'cust-001',
+            totalInCents: 3000,
+            currency: 'EUR',
+            lines: [
+                ['productName' => 'Widget', 'quantity' => 2, 'unitPriceInCents' => 1500, 'currency' => 'EUR'],
+            ],
+        ));
+
+        $shipment = $shipmentRepo->findByOrderRef(LegacyOrderRef::fromExternalId('order-acl-int-001'));
+        self::assertNotNull($shipment, 'ACL consumer must create a shipment request.');
+        self::assertCount(1, $gateway->sentRequests());
+    }
+}

tests/Integration/Sales/OhsApiTest.php

@@ -0,0 +1,94 @@
+<?php
+
+declare(strict_types=1);
+
+namespace MiniShop\Tests\Integration\Sales;
+
+use MiniShop\Contracts\Sales\V1\Api\OrderView;
+use MiniShop\Sales\Application\Command\PlaceOrder;
+use MiniShop\Sales\Application\Command\PlaceOrderHandler;
+use MiniShop\Sales\Application\Query\GetOrderById;
+use MiniShop\Sales\Application\Query\GetOrderByIdHandler;
+use MiniShop\Sales\Domain\Model\OrderLine;
+use MiniShop\Sales\Interfaces\Http\Api\V1\OrderViewAssembler;
+use MiniShop\Sales\Infrastructure\Persistence\InMemoryOrderRepository;
+use MiniShop\Shared\Technical\SystemClock;
+use PHPUnit\Framework\TestCase;
+
+/**
+ * Test de l'Open Host Service : verifie que l'API OHS expose uniquement
+ * des DTOs du Published Language (OrderView) et jamais les modeles internes.
+ */
+final class OhsApiTest extends TestCase
+{
+    public function test_assembler_returns_order_view_contract(): void
+    {
+        $orderRepo = new InMemoryOrderRepository();
+        $clock = new SystemClock();
+        $assembler = new OrderViewAssembler();
+
+        // Create a stub publisher that does nothing
+        $publisher = new class implements \MiniShop\Sales\Application\Port\SalesEventPublisher {
+            public function publishOrderPlaced(\MiniShop\Sales\Domain\Event\OrderPlaced $event): void {}
+            public function publishOrderConfirmed(\MiniShop\Sales\Domain\Event\OrderConfirmed $event): void {}
+            public function publishOrderCancelled(\MiniShop\Sales\Domain\Event\OrderCancelled $event): void {}
+        };
+
+        $placeHandler = new PlaceOrderHandler($orderRepo, $publisher, $clock);
+        $getHandler = new GetOrderByIdHandler($orderRepo);
+
+        $orderId = 'ohs-test-001';
+        ($placeHandler)(new PlaceOrder(
+            orderId: $orderId,
+            customerId: 'cust-001',
+            lines: [
+                ['productName' => 'Widget', 'quantity' => 2, 'unitPriceInCents' => 1500, 'currency' => 'EUR'],
+            ],
+        ));
+
+        $order = ($getHandler)(new GetOrderById($orderId));
+        $view = $assembler->toView($order);
+
+        // Verifie que le retour est un DTO du Published Language
+        self::assertInstanceOf(OrderView::class, $view);
+        self::assertSame($orderId, $view->orderId);
+        self::assertSame('placed', $view->status);
+        self::assertSame(3000, $view->totalInCents);
+        self::assertSame('EUR', $view->currency);
+        self::assertCount(1, $view->lines);
+    }
+
+    public function test_order_view_does_not_expose_internal_model(): void
+    {
+        $assembler = new OrderViewAssembler();
+        $orderRepo = new InMemoryOrderRepository();
+        $clock = new SystemClock();
+        $publisher = new class implements \MiniShop\Sales\Application\Port\SalesEventPublisher {
+            public function publishOrderPlaced(\MiniShop\Sales\Domain\Event\OrderPlaced $event): void {}
+            public function publishOrderConfirmed(\MiniShop\Sales\Domain\Event\OrderConfirmed $event): void {}
+            public function publishOrderCancelled(\MiniShop\Sales\Domain\Event\OrderCancelled $event): void {}
+        };
+
+        ($placeHandler = new PlaceOrderHandler($orderRepo, $publisher, $clock))(new PlaceOrder(
+            orderId: 'ohs-test-002',
+            customerId: 'cust-001',
+            lines: [['productName' => 'Widget', 'quantity' => 1, 'unitPriceInCents' => 1000, 'currency' => 'EUR']],
+        ));
+
+        $order = (new GetOrderByIdHandler($orderRepo))(new GetOrderById('ohs-test-002'));
+        $view = $assembler->toView($order);
+
+        $json = json_encode($view, JSON_THROW_ON_ERROR);
+        $decoded = json_decode($json, true, flags: JSON_THROW_ON_ERROR);
+
+        // Le JSON ne doit contenir que les champs du Published Language
+        $allowedKeys = ['orderId', 'customerId', 'status', 'totalInCents', 'currency', 'lines'];
+        self::assertSame($allowedKeys, array_keys($decoded));
+
+        // Les lignes ne doivent pas contenir de types internes (Money, OrderLine)
+        $lineKeys = array_keys($decoded['lines'][0]);
+        self::assertContains('productName', $lineKeys);
+        self::assertContains('lineTotalInCents', $lineKeys);
+        self::assertNotContains('unitPrice', $lineKeys); // pas d'objet Money
+    }
+}

tests/Unit/LegacyFulfillment/Infrastructure/AntiCorruption/LegacyShipmentAclTest.php

@@ -0,0 +1,99 @@
+<?php
+
+declare(strict_types=1);
+
+namespace MiniShop\Tests\Unit\LegacyFulfillment\Infrastructure\AntiCorruption;
+
+use MiniShop\Contracts\Sales\V1\Event\OrderConfirmed;
+use MiniShop\LegacyFulfillment\Infrastructure\AntiCorruption\LegacyShipmentAcl;
+use PHPUnit\Framework\TestCase;
+
+/**
+ * Tests du mapping ACL : sales.v1.OrderConfirmed → LegacyCreateShipmentCommand.
+ */
+final class LegacyShipmentAclTest extends TestCase
+{
+    private LegacyShipmentAcl $acl;
+
+    protected function setUp(): void
+    {
+        $this->acl = new LegacyShipmentAcl();
+    }
+
+    public function test_maps_order_ref_with_legacy_prefix(): void
+    {
+        $command = $this->acl->fromSalesOrderConfirmed($this->createMessage());
+
+        self::assertStringStartsWith('LEG-', $command->ord_ref);
+        self::assertSame('LEG-order-acl-001', $command->ord_ref);
+    }
+
+    public function test_truncates_recipient_name(): void
+    {
+        $message = new OrderConfirmed(
+            orderId: 'order-001',
+            customerId: 'very-long-customer-id-that-exceeds-thirty-five-characters-limit',
+            totalInCents: 1000,
+            currency: 'EUR',
+            lines: [['productName' => 'X', 'quantity' => 1, 'unitPriceInCents' => 1000, 'currency' => 'EUR']],
+        );
+
+        $command = $this->acl->fromSalesOrderConfirmed($message);
+
+        self::assertLessThanOrEqual(35, mb_strlen($command->rcpt_nm));
+    }
+
+    public function test_calculates_weight_from_line_count(): void
+    {
+        $command = $this->acl->fromSalesOrderConfirmed($this->createMessage(lineCount: 3));
+
+        self::assertSame(1500, $command->wgt_g); // 3 * 500g
+    }
+
+    public function test_minimum_weight_is_100g(): void
+    {
+        $command = $this->acl->fromSalesOrderConfirmed($this->createMessage(lineCount: 0));
+
+        self::assertGreaterThanOrEqual(100, $command->wgt_g);
+    }
+
+    public function test_status_is_new(): void
+    {
+        $command = $this->acl->fromSalesOrderConfirmed($this->createMessage());
+
+        self::assertSame('NEW', $command->sts);
+    }
+
+    public function test_date_format_is_legacy_yyyymmdd(): void
+    {
+        $command = $this->acl->fromSalesOrderConfirmed($this->createMessage());
+
+        self::assertMatchesRegularExpression('/^\d{8}$/', $command->req_dt);
+    }
+
+    public function test_description_contains_order_ref_and_article_count(): void
+    {
+        $command = $this->acl->fromSalesOrderConfirmed($this->createMessage(lineCount: 2));
+
+        self::assertStringContainsString('CMD-', $command->desc);
+        self::assertStringContainsString('2 articles', $command->desc);
+    }
+
+    private function createMessage(int $lineCount = 1): OrderConfirmed
+    {
+        $lines = array_fill(0, $lineCount, [
+            'productName' => 'Widget',
+            'quantity' => 1,
+            'unitPriceInCents' => 1000,
+            'currency' => 'EUR',
+        ]);
+
+        return new OrderConfirmed(
+            orderId: 'order-acl-001',
+            customerId: 'cust-001',
+            totalInCents: $lineCount * 1000,
+            currency: 'EUR',
+            lines: $lines,
+        );
+    }
+}