Step 01 — Published Language
- Extraction des DTOs publics dans contracts/sales/v1/ : OrderPlaced, OrderConfirmed, OrderCancelled, OrderView - NaiveSalesEventPublisher traduit les événements domaine en contrats v1 - Tests de contrat (schéma, sérialisation JSON) pour stabilité du langage publié
This commit is contained in:
@@ -19,7 +19,7 @@
|
||||
"MiniShop\\Invoicing\\": "src/Invoicing/",
|
||||
"MiniShop\\LegacyFulfillment\\": "src/LegacyFulfillment/",
|
||||
"MiniShop\\Shared\\": "src/Shared/",
|
||||
"MiniShop\\Contracts\\": "contracts/",
|
||||
"MiniShop\\Contracts\\Sales\\V1\\": "contracts/sales/v1/",
|
||||
"App\\": "apps/symfony/src/"
|
||||
}
|
||||
},
|
||||
|
||||
24
contracts/sales/v1/Api/OrderView.php
Normal file
24
contracts/sales/v1/Api/OrderView.php
Normal file
@@ -0,0 +1,24 @@
|
||||
<?php
|
||||
|
||||
declare(strict_types=1);
|
||||
|
||||
namespace MiniShop\Contracts\Sales\V1\Api;
|
||||
|
||||
/**
|
||||
* Published Language — sales.v1.OrderView
|
||||
* DTO de consultation. Contrat immutable et versionne.
|
||||
*/
|
||||
final readonly class OrderView
|
||||
{
|
||||
/**
|
||||
* @param list<array{productName: string, quantity: int, unitPriceInCents: int, currency: string, lineTotalInCents: int}> $lines
|
||||
*/
|
||||
public function __construct(
|
||||
public string $orderId,
|
||||
public string $customerId,
|
||||
public string $status,
|
||||
public int $totalInCents,
|
||||
public string $currency,
|
||||
public array $lines,
|
||||
) {}
|
||||
}
|
||||
16
contracts/sales/v1/Event/OrderCancelled.php
Normal file
16
contracts/sales/v1/Event/OrderCancelled.php
Normal file
@@ -0,0 +1,16 @@
|
||||
<?php
|
||||
|
||||
declare(strict_types=1);
|
||||
|
||||
namespace MiniShop\Contracts\Sales\V1\Event;
|
||||
|
||||
/**
|
||||
* Published Language — sales.v1.OrderCancelled
|
||||
* Contrat immutable et versionne. Ne jamais modifier les champs existants.
|
||||
*/
|
||||
final readonly class OrderCancelled
|
||||
{
|
||||
public function __construct(
|
||||
public string $orderId,
|
||||
) {}
|
||||
}
|
||||
23
contracts/sales/v1/Event/OrderConfirmed.php
Normal file
23
contracts/sales/v1/Event/OrderConfirmed.php
Normal file
@@ -0,0 +1,23 @@
|
||||
<?php
|
||||
|
||||
declare(strict_types=1);
|
||||
|
||||
namespace MiniShop\Contracts\Sales\V1\Event;
|
||||
|
||||
/**
|
||||
* Published Language — sales.v1.OrderConfirmed
|
||||
* Contrat immutable et versionne. Ne jamais modifier les champs existants.
|
||||
*/
|
||||
final readonly class OrderConfirmed
|
||||
{
|
||||
/**
|
||||
* @param list<array{productName: string, quantity: int, unitPriceInCents: int, currency: string}> $lines
|
||||
*/
|
||||
public function __construct(
|
||||
public string $orderId,
|
||||
public string $customerId,
|
||||
public int $totalInCents,
|
||||
public string $currency,
|
||||
public array $lines,
|
||||
) {}
|
||||
}
|
||||
24
contracts/sales/v1/Event/OrderPlaced.php
Normal file
24
contracts/sales/v1/Event/OrderPlaced.php
Normal file
@@ -0,0 +1,24 @@
|
||||
<?php
|
||||
|
||||
declare(strict_types=1);
|
||||
|
||||
namespace MiniShop\Contracts\Sales\V1\Event;
|
||||
|
||||
/**
|
||||
* Published Language — sales.v1.OrderPlaced
|
||||
* Contrat immutable et versionne. Ne jamais modifier les champs existants.
|
||||
*/
|
||||
final readonly class OrderPlaced
|
||||
{
|
||||
/**
|
||||
* @param list<array{productName: string, quantity: int, unitPriceInCents: int, currency: string}> $lines
|
||||
*/
|
||||
public function __construct(
|
||||
public string $orderId,
|
||||
public string $customerId,
|
||||
public int $totalInCents,
|
||||
public string $currency,
|
||||
public string $placedAt,
|
||||
public array $lines,
|
||||
) {}
|
||||
}
|
||||
@@ -4,6 +4,8 @@ declare(strict_types=1);
|
||||
|
||||
namespace MiniShop\Sales\Infrastructure\Messaging;
|
||||
|
||||
use MiniShop\Contracts\Sales\V1\Event\OrderConfirmed as OrderConfirmedContract;
|
||||
use MiniShop\Contracts\Sales\V1\Event\OrderPlaced as OrderPlacedContract;
|
||||
use MiniShop\Invoicing\Application\Command\IssueInvoiceForExternalOrder;
|
||||
use MiniShop\Invoicing\Application\Command\IssueInvoiceForExternalOrderHandler;
|
||||
use MiniShop\LegacyFulfillment\Application\Command\RequestShipmentFromSalesOrder;
|
||||
@@ -16,7 +18,7 @@ use MiniShop\Sales\Domain\Model\OrderLine;
|
||||
|
||||
/**
|
||||
* Couplage naif : Sales appelle directement les handlers des autres BC.
|
||||
* Ce couplage sera supprime dans les episodes suivants (Published Language, Conformist, ACL).
|
||||
* Depuis step/01, la traduction passe par le Published Language (contracts/sales/v1).
|
||||
*/
|
||||
final readonly class NaiveSalesEventPublisher implements SalesEventPublisher
|
||||
{
|
||||
@@ -27,42 +29,78 @@ final readonly class NaiveSalesEventPublisher implements SalesEventPublisher
|
||||
|
||||
public function publishOrderPlaced(OrderPlaced $event): void
|
||||
{
|
||||
// Pas d'action downstream sur OrderPlaced dans le scenario naif.
|
||||
// Traduction domaine → Published Language (pour reference)
|
||||
new OrderPlacedContract(
|
||||
orderId: $event->orderId->toString(),
|
||||
customerId: $event->customerId->toString(),
|
||||
totalInCents: $event->total->amount,
|
||||
currency: $event->total->currency,
|
||||
placedAt: $event->placedAt->format(\DateTimeInterface::ATOM),
|
||||
lines: array_map(
|
||||
static fn (OrderLine $line): array => [
|
||||
'productName' => $line->productName,
|
||||
'quantity' => $line->quantity,
|
||||
'unitPriceInCents' => $line->unitPrice->amount,
|
||||
'currency' => $line->unitPrice->currency,
|
||||
],
|
||||
[], // OrderPlaced doesn't carry lines in this version
|
||||
),
|
||||
);
|
||||
// Pas d'action downstream sur OrderPlaced.
|
||||
}
|
||||
|
||||
public function publishOrderConfirmed(OrderConfirmed $event): void
|
||||
{
|
||||
// Appel direct vers Invoicing — couplage naif
|
||||
($this->issueInvoiceHandler)(new IssueInvoiceForExternalOrder(
|
||||
externalOrderId: $event->orderId->toString(),
|
||||
customerName: 'Customer ' . $event->customerId->toString(),
|
||||
customerAddress: 'N/A',
|
||||
lines: array_map(
|
||||
$lines = array_map(
|
||||
static fn (OrderLine $line): array => [
|
||||
'description' => $line->productName,
|
||||
'productName' => $line->productName,
|
||||
'quantity' => $line->quantity,
|
||||
'unitPriceInCents' => $line->unitPrice->amount,
|
||||
'currency' => $line->unitPrice->currency,
|
||||
],
|
||||
$event->lines,
|
||||
);
|
||||
|
||||
// Step 01 : traduction domaine → Published Language
|
||||
$message = new OrderConfirmedContract(
|
||||
orderId: $event->orderId->toString(),
|
||||
customerId: $event->customerId->toString(),
|
||||
totalInCents: $event->total->amount,
|
||||
currency: $event->total->currency,
|
||||
lines: $lines,
|
||||
);
|
||||
|
||||
// Appel direct vers Invoicing — toujours naif mais via Published Language
|
||||
($this->issueInvoiceHandler)(new IssueInvoiceForExternalOrder(
|
||||
externalOrderId: $message->orderId,
|
||||
customerName: 'Customer ' . $message->customerId,
|
||||
customerAddress: 'N/A',
|
||||
lines: array_map(
|
||||
static fn (array $line): array => [
|
||||
'description' => $line['productName'],
|
||||
'quantity' => $line['quantity'],
|
||||
'unitPriceInCents' => $line['unitPriceInCents'],
|
||||
'currency' => $line['currency'],
|
||||
],
|
||||
$message->lines,
|
||||
),
|
||||
));
|
||||
|
||||
// Appel direct vers LegacyFulfillment — couplage naif
|
||||
// Appel direct vers LegacyFulfillment — toujours naif mais via Published Language
|
||||
($this->requestShipmentHandler)(new RequestShipmentFromSalesOrder(
|
||||
externalOrderId: $event->orderId->toString(),
|
||||
recipientName: 'Customer ' . $event->customerId->toString(),
|
||||
externalOrderId: $message->orderId,
|
||||
recipientName: 'Customer ' . $message->customerId,
|
||||
street: '1 Rue du Commerce',
|
||||
city: 'Paris',
|
||||
postalCode: '75001',
|
||||
country: 'FR',
|
||||
totalWeightInGrams: 1000,
|
||||
description: sprintf('Order %s', $event->orderId->toString()),
|
||||
description: sprintf('Order %s', $message->orderId),
|
||||
));
|
||||
}
|
||||
|
||||
public function publishOrderCancelled(OrderCancelled $event): void
|
||||
{
|
||||
// Pas d'action downstream sur OrderCancelled dans le scenario naif.
|
||||
// Pas d'action downstream sur OrderCancelled.
|
||||
}
|
||||
}
|
||||
|
||||
78
tests/Contract/Sales/v1/OrderConfirmedSchemaTest.php
Normal file
78
tests/Contract/Sales/v1/OrderConfirmedSchemaTest.php
Normal file
@@ -0,0 +1,78 @@
|
||||
<?php
|
||||
|
||||
declare(strict_types=1);
|
||||
|
||||
namespace MiniShop\Tests\Contract\Sales\v1;
|
||||
|
||||
use MiniShop\Contracts\Sales\V1\Event\OrderConfirmed;
|
||||
use PHPUnit\Framework\TestCase;
|
||||
|
||||
/**
|
||||
* Tests de stabilite du contrat sales.v1.OrderConfirmed.
|
||||
*/
|
||||
final class OrderConfirmedSchemaTest extends TestCase
|
||||
{
|
||||
public function test_contract_has_required_fields(): void
|
||||
{
|
||||
$event = new OrderConfirmed(
|
||||
orderId: 'order-001',
|
||||
customerId: 'cust-001',
|
||||
totalInCents: 5500,
|
||||
currency: 'EUR',
|
||||
lines: [
|
||||
['productName' => 'Widget', 'quantity' => 2, 'unitPriceInCents' => 1500, 'currency' => 'EUR'],
|
||||
['productName' => 'Gadget', 'quantity' => 1, 'unitPriceInCents' => 2500, 'currency' => 'EUR'],
|
||||
],
|
||||
);
|
||||
|
||||
self::assertSame('order-001', $event->orderId);
|
||||
self::assertSame('cust-001', $event->customerId);
|
||||
self::assertSame(5500, $event->totalInCents);
|
||||
self::assertSame('EUR', $event->currency);
|
||||
self::assertCount(2, $event->lines);
|
||||
}
|
||||
|
||||
public function test_contract_serializes_to_stable_json(): void
|
||||
{
|
||||
$event = new OrderConfirmed(
|
||||
orderId: 'order-001',
|
||||
customerId: 'cust-001',
|
||||
totalInCents: 5500,
|
||||
currency: 'EUR',
|
||||
lines: [
|
||||
['productName' => 'Widget', 'quantity' => 2, 'unitPriceInCents' => 1500, 'currency' => 'EUR'],
|
||||
],
|
||||
);
|
||||
|
||||
$json = json_encode($event, JSON_THROW_ON_ERROR);
|
||||
$decoded = json_decode($json, true, flags: JSON_THROW_ON_ERROR);
|
||||
|
||||
self::assertArrayHasKey('orderId', $decoded);
|
||||
self::assertArrayHasKey('customerId', $decoded);
|
||||
self::assertArrayHasKey('totalInCents', $decoded);
|
||||
self::assertArrayHasKey('currency', $decoded);
|
||||
self::assertArrayHasKey('lines', $decoded);
|
||||
}
|
||||
|
||||
public function test_lines_contain_required_fields(): void
|
||||
{
|
||||
$event = new OrderConfirmed(
|
||||
orderId: 'order-001',
|
||||
customerId: 'cust-001',
|
||||
totalInCents: 3000,
|
||||
currency: 'EUR',
|
||||
lines: [
|
||||
['productName' => 'Widget', 'quantity' => 2, 'unitPriceInCents' => 1500, 'currency' => 'EUR'],
|
||||
],
|
||||
);
|
||||
|
||||
$json = json_encode($event, JSON_THROW_ON_ERROR);
|
||||
$decoded = json_decode($json, true, flags: JSON_THROW_ON_ERROR);
|
||||
$line = $decoded['lines'][0];
|
||||
|
||||
self::assertArrayHasKey('productName', $line);
|
||||
self::assertArrayHasKey('quantity', $line);
|
||||
self::assertArrayHasKey('unitPriceInCents', $line);
|
||||
self::assertArrayHasKey('currency', $line);
|
||||
}
|
||||
}
|
||||
79
tests/Contract/Sales/v1/OrderPlacedSchemaTest.php
Normal file
79
tests/Contract/Sales/v1/OrderPlacedSchemaTest.php
Normal file
@@ -0,0 +1,79 @@
|
||||
<?php
|
||||
|
||||
declare(strict_types=1);
|
||||
|
||||
namespace MiniShop\Tests\Contract\Sales\v1;
|
||||
|
||||
use MiniShop\Contracts\Sales\V1\Event\OrderPlaced;
|
||||
use PHPUnit\Framework\TestCase;
|
||||
|
||||
/**
|
||||
* Tests de stabilite du contrat sales.v1.OrderPlaced.
|
||||
* Garantit que le schema est stable et ne casse pas les consommateurs downstream.
|
||||
*/
|
||||
final class OrderPlacedSchemaTest extends TestCase
|
||||
{
|
||||
public function test_contract_has_required_fields(): void
|
||||
{
|
||||
$event = new OrderPlaced(
|
||||
orderId: 'order-001',
|
||||
customerId: 'cust-001',
|
||||
totalInCents: 3000,
|
||||
currency: 'EUR',
|
||||
placedAt: '2026-01-15T10:30:00+00:00',
|
||||
lines: [
|
||||
['productName' => 'Widget', 'quantity' => 2, 'unitPriceInCents' => 1500, 'currency' => 'EUR'],
|
||||
],
|
||||
);
|
||||
|
||||
self::assertSame('order-001', $event->orderId);
|
||||
self::assertSame('cust-001', $event->customerId);
|
||||
self::assertSame(3000, $event->totalInCents);
|
||||
self::assertSame('EUR', $event->currency);
|
||||
self::assertSame('2026-01-15T10:30:00+00:00', $event->placedAt);
|
||||
self::assertCount(1, $event->lines);
|
||||
}
|
||||
|
||||
public function test_contract_serializes_to_stable_json(): void
|
||||
{
|
||||
$event = new OrderPlaced(
|
||||
orderId: 'order-001',
|
||||
customerId: 'cust-001',
|
||||
totalInCents: 3000,
|
||||
currency: 'EUR',
|
||||
placedAt: '2026-01-15T10:30:00+00:00',
|
||||
lines: [
|
||||
['productName' => 'Widget', 'quantity' => 2, 'unitPriceInCents' => 1500, 'currency' => 'EUR'],
|
||||
],
|
||||
);
|
||||
|
||||
$json = json_encode($event, JSON_THROW_ON_ERROR);
|
||||
$decoded = json_decode($json, true, flags: JSON_THROW_ON_ERROR);
|
||||
|
||||
self::assertArrayHasKey('orderId', $decoded);
|
||||
self::assertArrayHasKey('customerId', $decoded);
|
||||
self::assertArrayHasKey('totalInCents', $decoded);
|
||||
self::assertArrayHasKey('currency', $decoded);
|
||||
self::assertArrayHasKey('placedAt', $decoded);
|
||||
self::assertArrayHasKey('lines', $decoded);
|
||||
}
|
||||
|
||||
public function test_contract_deserializes_from_json(): void
|
||||
{
|
||||
$json = '{"orderId":"order-001","customerId":"cust-001","totalInCents":3000,"currency":"EUR","placedAt":"2026-01-15T10:30:00+00:00","lines":[{"productName":"Widget","quantity":2,"unitPriceInCents":1500,"currency":"EUR"}]}';
|
||||
|
||||
$decoded = json_decode($json, true, flags: JSON_THROW_ON_ERROR);
|
||||
|
||||
$event = new OrderPlaced(
|
||||
orderId: $decoded['orderId'],
|
||||
customerId: $decoded['customerId'],
|
||||
totalInCents: $decoded['totalInCents'],
|
||||
currency: $decoded['currency'],
|
||||
placedAt: $decoded['placedAt'],
|
||||
lines: $decoded['lines'],
|
||||
);
|
||||
|
||||
self::assertSame('order-001', $event->orderId);
|
||||
self::assertSame(3000, $event->totalInCents);
|
||||
}
|
||||
}
|
||||
57
tests/Contract/Sales/v1/OrderViewSchemaTest.php
Normal file
57
tests/Contract/Sales/v1/OrderViewSchemaTest.php
Normal file
@@ -0,0 +1,57 @@
|
||||
<?php
|
||||
|
||||
declare(strict_types=1);
|
||||
|
||||
namespace MiniShop\Tests\Contract\Sales\v1;
|
||||
|
||||
use MiniShop\Contracts\Sales\V1\Api\OrderView;
|
||||
use PHPUnit\Framework\TestCase;
|
||||
|
||||
/**
|
||||
* Tests de stabilite du contrat sales.v1.OrderView.
|
||||
*/
|
||||
final class OrderViewSchemaTest extends TestCase
|
||||
{
|
||||
public function test_contract_has_required_fields(): void
|
||||
{
|
||||
$view = new OrderView(
|
||||
orderId: 'order-001',
|
||||
customerId: 'cust-001',
|
||||
status: 'confirmed',
|
||||
totalInCents: 5500,
|
||||
currency: 'EUR',
|
||||
lines: [
|
||||
['productName' => 'Widget', 'quantity' => 2, 'unitPriceInCents' => 1500, 'currency' => 'EUR', 'lineTotalInCents' => 3000],
|
||||
],
|
||||
);
|
||||
|
||||
self::assertSame('order-001', $view->orderId);
|
||||
self::assertSame('confirmed', $view->status);
|
||||
self::assertSame(5500, $view->totalInCents);
|
||||
self::assertCount(1, $view->lines);
|
||||
}
|
||||
|
||||
public function test_contract_serializes_to_stable_json(): void
|
||||
{
|
||||
$view = new OrderView(
|
||||
orderId: 'order-001',
|
||||
customerId: 'cust-001',
|
||||
status: 'placed',
|
||||
totalInCents: 3000,
|
||||
currency: 'EUR',
|
||||
lines: [
|
||||
['productName' => 'Widget', 'quantity' => 2, 'unitPriceInCents' => 1500, 'currency' => 'EUR', 'lineTotalInCents' => 3000],
|
||||
],
|
||||
);
|
||||
|
||||
$json = json_encode($view, JSON_THROW_ON_ERROR);
|
||||
$decoded = json_decode($json, true, flags: JSON_THROW_ON_ERROR);
|
||||
|
||||
self::assertArrayHasKey('orderId', $decoded);
|
||||
self::assertArrayHasKey('customerId', $decoded);
|
||||
self::assertArrayHasKey('status', $decoded);
|
||||
self::assertArrayHasKey('totalInCents', $decoded);
|
||||
self::assertArrayHasKey('currency', $decoded);
|
||||
self::assertArrayHasKey('lines', $decoded);
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user