Story 1-7 avait posé les fondations d'audit trail mais laissé en dehors du
périmètre initial les événements notes/évaluations, qui étaient alors non
couverts par les domaines. Avec la clôture des epics notation, ces actions
sensibles (création/modification/suppression d'évaluation, saisie/modification
de note, publication) doivent maintenant être tracées pour répondre aux
exigences RGPD et faciliter la résolution des litiges parent/enseignant.
Les événements de domaine existants ne transportaient pas tous les champs
nécessaires à l'audit (ancien/nouveau titre, description, barème, coefficient,
date, studentId). L'enrichissement de leur payload permet aux handlers d'audit
de journaliser les diffs complets via AuditLogger, sans que les autres
consommateurs (recalcul de moyennes) n'aient besoin de changer leur logique.
Au passage, le test E2E student-grades AC5 ("Nouveau" badge) visait
séquentiellement '.grade-card' puis '.badge-new' : la fenêtre de 3 s avant
markGradesSeen pouvait se refermer entre les deux attentes sur Firefox CI.
Un seul expect combiné '.grade-card .badge-new' élimine cette course.
143 lines
5.0 KiB
PHP
143 lines
5.0 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
namespace App\Tests\Functional\Scolarite\Infrastructure\EventHandler;
|
|
|
|
use App\Scolarite\Domain\Event\NoteModifiee;
|
|
use App\Scolarite\Domain\Event\NoteSaisie;
|
|
use App\Scolarite\Domain\Model\Grade\GradeId;
|
|
use App\Scolarite\Infrastructure\EventHandler\AuditGradeEventsHandler;
|
|
use DateTimeImmutable;
|
|
use Doctrine\DBAL\Connection;
|
|
|
|
use const JSON_THROW_ON_ERROR;
|
|
|
|
use PHPUnit\Framework\Attributes\Test;
|
|
use Ramsey\Uuid\Uuid;
|
|
use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
|
|
|
|
/**
|
|
* Vérifie le bout-en-bout de l'audit des événements Grade : le handler,
|
|
* connecté à l'AuditLogger réel et à la base, écrit une ligne immuable
|
|
* dans `audit_log` avec le bon payload (création / diff).
|
|
*/
|
|
final class AuditGradeEventsHandlerFunctionalTest extends KernelTestCase
|
|
{
|
|
private Connection $connection;
|
|
private AuditGradeEventsHandler $handler;
|
|
|
|
protected function setUp(): void
|
|
{
|
|
self::bootKernel();
|
|
|
|
/** @var Connection $connection */
|
|
$connection = static::getContainer()->get(Connection::class);
|
|
$this->connection = $connection;
|
|
|
|
/** @var AuditGradeEventsHandler $handler */
|
|
$handler = static::getContainer()->get(AuditGradeEventsHandler::class);
|
|
$this->handler = $handler;
|
|
}
|
|
|
|
protected function tearDown(): void
|
|
{
|
|
// audit_log est append-only : pas de DELETE possible, on filtre par UUID unique dans chaque test
|
|
parent::tearDown();
|
|
}
|
|
|
|
#[Test]
|
|
public function handleNoteSaisieWritesAuditEntryToDatabase(): void
|
|
{
|
|
$gradeId = GradeId::generate();
|
|
$evaluationId = Uuid::uuid4()->toString();
|
|
$studentId = Uuid::uuid4()->toString();
|
|
$createdBy = Uuid::uuid4()->toString();
|
|
|
|
$event = new NoteSaisie(
|
|
gradeId: $gradeId,
|
|
evaluationId: $evaluationId,
|
|
studentId: $studentId,
|
|
value: 15.5,
|
|
status: 'draft',
|
|
createdBy: $createdBy,
|
|
occurredOn: new DateTimeImmutable(),
|
|
);
|
|
|
|
$this->handler->handleNoteSaisie($event);
|
|
|
|
$entry = $this->connection->fetchAssociative(
|
|
'SELECT * FROM audit_log WHERE aggregate_id = ? AND event_type = ? ORDER BY occurred_at DESC LIMIT 1',
|
|
[$gradeId->value->toString(), 'NoteSaisie'],
|
|
);
|
|
|
|
self::assertNotFalse($entry, 'Audit log entry should exist after NoteSaisie');
|
|
self::assertSame('Grade', $entry['aggregate_type']);
|
|
|
|
$payload = self::decodePayload($entry['payload']);
|
|
self::assertSame([], $payload['old_values']);
|
|
self::assertSame($evaluationId, $payload['new_values']['evaluation_id']);
|
|
self::assertSame($studentId, $payload['new_values']['student_id']);
|
|
self::assertSame(15.5, $payload['new_values']['value']);
|
|
self::assertSame('draft', $payload['new_values']['status']);
|
|
self::assertSame($createdBy, $payload['new_values']['created_by']);
|
|
|
|
self::assertArrayHasKey('metadata', $entry);
|
|
$metadata = self::decodePayload($entry['metadata']);
|
|
self::assertArrayHasKey('correlation_id', $metadata);
|
|
self::assertArrayHasKey('occurred_at', $metadata);
|
|
}
|
|
|
|
#[Test]
|
|
public function handleNoteModifieeWritesAuditEntryWithDiff(): void
|
|
{
|
|
$gradeId = GradeId::generate();
|
|
$evaluationId = Uuid::uuid4()->toString();
|
|
$studentId = Uuid::uuid4()->toString();
|
|
$modifiedBy = Uuid::uuid4()->toString();
|
|
|
|
$event = new NoteModifiee(
|
|
gradeId: $gradeId,
|
|
evaluationId: $evaluationId,
|
|
studentId: $studentId,
|
|
oldValue: 12.0,
|
|
newValue: 14.5,
|
|
oldStatus: 'draft',
|
|
newStatus: 'published',
|
|
modifiedBy: $modifiedBy,
|
|
occurredOn: new DateTimeImmutable(),
|
|
);
|
|
|
|
$this->handler->handleNoteModifiee($event);
|
|
|
|
$entry = $this->connection->fetchAssociative(
|
|
'SELECT * FROM audit_log WHERE aggregate_id = ? AND event_type = ? ORDER BY occurred_at DESC LIMIT 1',
|
|
[$gradeId->value->toString(), 'NoteModifiee'],
|
|
);
|
|
|
|
self::assertNotFalse($entry, 'Audit log entry should exist after NoteModifiee');
|
|
self::assertSame('Grade', $entry['aggregate_type']);
|
|
|
|
$payload = self::decodePayload($entry['payload']);
|
|
self::assertSame(['value' => 12.0, 'status' => 'draft'], $payload['old_values']);
|
|
self::assertSame(14.5, $payload['new_values']['value']);
|
|
self::assertSame('published', $payload['new_values']['status']);
|
|
self::assertSame($modifiedBy, $payload['new_values']['modified_by']);
|
|
self::assertSame($evaluationId, $payload['new_values']['evaluation_id']);
|
|
self::assertSame($studentId, $payload['new_values']['student_id']);
|
|
}
|
|
|
|
/**
|
|
* @return array<string, mixed>
|
|
*/
|
|
private static function decodePayload(mixed $raw): array
|
|
{
|
|
self::assertIsString($raw);
|
|
|
|
/** @var array<string, mixed> $decoded */
|
|
$decoded = json_decode($raw, true, 512, JSON_THROW_ON_ERROR);
|
|
|
|
return $decoded;
|
|
}
|
|
}
|