feat: Attribution de rôles multiples par utilisateur

Les utilisateurs Classeo étaient limités à un seul rôle, alors que dans la réalité scolaire un directeur peut aussi être enseignant, ou un parent peut avoir un rôle vie scolaire. Cette limitation obligeait à créer des comptes distincts par fonction. Le modèle User supporte désormais plusieurs rôles simultanés avec basculement via le header. L'admin peut attribuer/retirer des rôles depuis l'interface de gestion, avec des garde-fous : pas d'auto- destitution, pas d'escalade de privilèges (seul SUPER_ADMIN peut attribuer SUPER_ADMIN), vérification du statut actif pour le switch de rôle, et TTL explicite sur le cache de rôle actif.
2026-02-10 07:57:43 +01:00
parent 9ccad77bf0
commit e930c505df
93 changed files with 2527 additions and 165 deletions
--- a/backend/tests/Unit/Administration/Application/Command/AssignRoleHandlerTest.php
+++ b/backend/tests/Unit/Administration/Application/Command/AssignRoleHandlerTest.php
@@ -0,0 +1,116 @@
+<?php
+
+declare(strict_types=1);
+
+namespace App\Tests\Unit\Administration\Application\Command;
+
+use App\Administration\Application\Command\AssignRole\AssignRoleCommand;
+use App\Administration\Application\Command\AssignRole\AssignRoleHandler;
+use App\Administration\Domain\Event\RoleAttribue;
+use App\Administration\Domain\Exception\RoleDejaAttribueException;
+use App\Administration\Domain\Model\User\Email;
+use App\Administration\Domain\Model\User\Role;
+use App\Administration\Domain\Model\User\User;
+use App\Administration\Infrastructure\Persistence\InMemory\InMemoryUserRepository;
+use App\Shared\Domain\Clock;
+use App\Shared\Domain\Tenant\TenantId;
+use DateTimeImmutable;
+use InvalidArgumentException;
+use PHPUnit\Framework\Attributes\Test;
+use PHPUnit\Framework\TestCase;
+
+final class AssignRoleHandlerTest extends TestCase
+{
+    private const string TENANT_ID = '550e8400-e29b-41d4-a716-446655440002';
+
+    private InMemoryUserRepository $userRepository;
+    private AssignRoleHandler $handler;
+
+    protected function setUp(): void
+    {
+        $this->userRepository = new InMemoryUserRepository();
+
+        $clock = new class implements Clock {
+            public function now(): DateTimeImmutable
+            {
+                return new DateTimeImmutable('2026-02-08 10:00:00');
+            }
+        };
+
+        $this->handler = new AssignRoleHandler($this->userRepository, $clock);
+    }
+
+    #[Test]
+    public function itAssignsRoleToUser(): void
+    {
+        $user = $this->createUser(Role::PROF);
+        $this->userRepository->save($user);
+
+        $result = ($this->handler)(new AssignRoleCommand(
+            userId: (string) $user->id,
+            role: Role::PARENT->value,
+        ));
+
+        self::assertTrue($result->aLeRole(Role::PROF));
+        self::assertTrue($result->aLeRole(Role::PARENT));
+    }
+
+    #[Test]
+    public function itRecordsRoleAttribueEvent(): void
+    {
+        $user = $this->createUser(Role::PROF);
+        $this->userRepository->save($user);
+        $user->pullDomainEvents();
+
+        ($this->handler)(new AssignRoleCommand(
+            userId: (string) $user->id,
+            role: Role::PARENT->value,
+        ));
+
+        $savedUser = $this->userRepository->get($user->id);
+        $events = $savedUser->pullDomainEvents();
+
+        self::assertCount(1, $events);
+        self::assertInstanceOf(RoleAttribue::class, $events[0]);
+    }
+
+    #[Test]
+    public function itThrowsWhenRoleAlreadyAssigned(): void
+    {
+        $user = $this->createUser(Role::PROF);
+        $this->userRepository->save($user);
+
+        $this->expectException(RoleDejaAttribueException::class);
+
+        ($this->handler)(new AssignRoleCommand(
+            userId: (string) $user->id,
+            role: Role::PROF->value,
+        ));
+    }
+
+    #[Test]
+    public function itThrowsWhenRoleIsInvalid(): void
+    {
+        $user = $this->createUser(Role::PROF);
+        $this->userRepository->save($user);
+
+        $this->expectException(InvalidArgumentException::class);
+
+        ($this->handler)(new AssignRoleCommand(
+            userId: (string) $user->id,
+            role: 'ROLE_INVALID',
+        ));
+    }
+
+    private function createUser(Role $role): User
+    {
+        return User::creer(
+            email: new Email('user@example.com'),
+            role: $role,
+            tenantId: TenantId::fromString(self::TENANT_ID),
+            schoolName: 'École Alpha',
+            dateNaissance: null,
+            createdAt: new DateTimeImmutable('2026-01-15 10:00:00'),
+        );
+    }
+}
--- a/backend/tests/Unit/Administration/Application/Command/RemoveRoleHandlerTest.php
+++ b/backend/tests/Unit/Administration/Application/Command/RemoveRoleHandlerTest.php
@@ -0,0 +1,126 @@
+<?php
+
+declare(strict_types=1);
+
+namespace App\Tests\Unit\Administration\Application\Command;
+
+use App\Administration\Application\Command\RemoveRole\RemoveRoleCommand;
+use App\Administration\Application\Command\RemoveRole\RemoveRoleHandler;
+use App\Administration\Domain\Event\RoleRetire;
+use App\Administration\Domain\Exception\DernierRoleNonRetirableException;
+use App\Administration\Domain\Exception\RoleNonAttribueException;
+use App\Administration\Domain\Model\User\Email;
+use App\Administration\Domain\Model\User\Role;
+use App\Administration\Domain\Model\User\User;
+use App\Administration\Infrastructure\Persistence\InMemory\InMemoryUserRepository;
+use App\Shared\Domain\Clock;
+use App\Shared\Domain\Tenant\TenantId;
+use DateTimeImmutable;
+use PHPUnit\Framework\Attributes\Test;
+use PHPUnit\Framework\TestCase;
+
+final class RemoveRoleHandlerTest extends TestCase
+{
+    private const string TENANT_ID = '550e8400-e29b-41d4-a716-446655440002';
+
+    private InMemoryUserRepository $userRepository;
+    private RemoveRoleHandler $handler;
+
+    protected function setUp(): void
+    {
+        $this->userRepository = new InMemoryUserRepository();
+
+        $clock = new class implements Clock {
+            public function now(): DateTimeImmutable
+            {
+                return new DateTimeImmutable('2026-02-08 10:00:00');
+            }
+        };
+
+        $this->handler = new RemoveRoleHandler($this->userRepository, $clock);
+    }
+
+    #[Test]
+    public function itRemovesRoleFromUser(): void
+    {
+        $user = $this->createUserWithRoles(Role::PROF, Role::PARENT);
+        $this->userRepository->save($user);
+
+        $result = ($this->handler)(new RemoveRoleCommand(
+            userId: (string) $user->id,
+            role: Role::PARENT->value,
+        ));
+
+        self::assertTrue($result->aLeRole(Role::PROF));
+        self::assertFalse($result->aLeRole(Role::PARENT));
+    }
+
+    #[Test]
+    public function itRecordsRoleRetireEvent(): void
+    {
+        $user = $this->createUserWithRoles(Role::PROF, Role::PARENT);
+        $this->userRepository->save($user);
+        $user->pullDomainEvents();
+
+        ($this->handler)(new RemoveRoleCommand(
+            userId: (string) $user->id,
+            role: Role::PARENT->value,
+        ));
+
+        $savedUser = $this->userRepository->get($user->id);
+        $events = $savedUser->pullDomainEvents();
+
+        self::assertCount(1, $events);
+        self::assertInstanceOf(RoleRetire::class, $events[0]);
+    }
+
+    #[Test]
+    public function itThrowsWhenRoleNotAssigned(): void
+    {
+        $user = $this->createUser(Role::PROF);
+        $this->userRepository->save($user);
+
+        $this->expectException(RoleNonAttribueException::class);
+
+        ($this->handler)(new RemoveRoleCommand(
+            userId: (string) $user->id,
+            role: Role::PARENT->value,
+        ));
+    }
+
+    #[Test]
+    public function itThrowsWhenRemovingLastRole(): void
+    {
+        $user = $this->createUser(Role::PROF);
+        $this->userRepository->save($user);
+
+        $this->expectException(DernierRoleNonRetirableException::class);
+
+        ($this->handler)(new RemoveRoleCommand(
+            userId: (string) $user->id,
+            role: Role::PROF->value,
+        ));
+    }
+
+    private function createUser(Role $role): User
+    {
+        return User::creer(
+            email: new Email('user@example.com'),
+            role: $role,
+            tenantId: TenantId::fromString(self::TENANT_ID),
+            schoolName: 'École Alpha',
+            dateNaissance: null,
+            createdAt: new DateTimeImmutable('2026-01-15 10:00:00'),
+        );
+    }
+
+    private function createUserWithRoles(Role $role, Role ...$additionalRoles): User
+    {
+        $user = $this->createUser($role);
+        foreach ($additionalRoles as $r) {
+            $user->attribuerRole($r, new DateTimeImmutable());
+        }
+
+        return $user;
+    }
+}
--- a/backend/tests/Unit/Administration/Application/Command/UpdateUserRolesHandlerTest.php
+++ b/backend/tests/Unit/Administration/Application/Command/UpdateUserRolesHandlerTest.php
@@ -0,0 +1,119 @@
+<?php
+
+declare(strict_types=1);
+
+namespace App\Tests\Unit\Administration\Application\Command;
+
+use App\Administration\Application\Command\UpdateUserRoles\UpdateUserRolesCommand;
+use App\Administration\Application\Command\UpdateUserRoles\UpdateUserRolesHandler;
+use App\Administration\Application\Port\ActiveRoleStore;
+use App\Administration\Domain\Model\User\Email;
+use App\Administration\Domain\Model\User\Role;
+use App\Administration\Domain\Model\User\User;
+use App\Administration\Infrastructure\Persistence\InMemory\InMemoryUserRepository;
+use App\Shared\Domain\Clock;
+use App\Shared\Domain\Tenant\TenantId;
+use DateTimeImmutable;
+use InvalidArgumentException;
+use PHPUnit\Framework\Attributes\Test;
+use PHPUnit\Framework\TestCase;
+
+final class UpdateUserRolesHandlerTest extends TestCase
+{
+    private const string TENANT_ID = '550e8400-e29b-41d4-a716-446655440002';
+
+    private InMemoryUserRepository $userRepository;
+    private UpdateUserRolesHandler $handler;
+    private ActiveRoleStore $activeRoleStore;
+
+    protected function setUp(): void
+    {
+        $this->userRepository = new InMemoryUserRepository();
+
+        $clock = new class implements Clock {
+            public function now(): DateTimeImmutable
+            {
+                return new DateTimeImmutable('2026-02-08 10:00:00');
+            }
+        };
+
+        $this->activeRoleStore = $this->createMock(ActiveRoleStore::class);
+
+        $this->handler = new UpdateUserRolesHandler($this->userRepository, $clock, $this->activeRoleStore);
+    }
+
+    #[Test]
+    public function itUpdatesRolesBulk(): void
+    {
+        $user = $this->createUser(Role::PROF);
+        $this->userRepository->save($user);
+
+        $result = ($this->handler)(new UpdateUserRolesCommand(
+            userId: (string) $user->id,
+            roles: [Role::PARENT->value, Role::VIE_SCOLAIRE->value],
+        ));
+
+        self::assertFalse($result->aLeRole(Role::PROF));
+        self::assertTrue($result->aLeRole(Role::PARENT));
+        self::assertTrue($result->aLeRole(Role::VIE_SCOLAIRE));
+    }
+
+    #[Test]
+    public function itKeepsExistingRolesIfInTargetList(): void
+    {
+        $user = $this->createUser(Role::PROF);
+        $user->attribuerRole(Role::PARENT, new DateTimeImmutable());
+        $this->userRepository->save($user);
+
+        $result = ($this->handler)(new UpdateUserRolesCommand(
+            userId: (string) $user->id,
+            roles: [Role::PROF->value, Role::PARENT->value, Role::ADMIN->value],
+        ));
+
+        self::assertTrue($result->aLeRole(Role::PROF));
+        self::assertTrue($result->aLeRole(Role::PARENT));
+        self::assertTrue($result->aLeRole(Role::ADMIN));
+        self::assertCount(3, $result->roles);
+    }
+
+    #[Test]
+    public function itThrowsWhenEmptyRoles(): void
+    {
+        $user = $this->createUser(Role::PROF);
+        $this->userRepository->save($user);
+
+        $this->expectException(InvalidArgumentException::class);
+        $this->expectExceptionMessage('Au moins un rôle est requis.');
+
+        ($this->handler)(new UpdateUserRolesCommand(
+            userId: (string) $user->id,
+            roles: [],
+        ));
+    }
+
+    #[Test]
+    public function itThrowsWhenInvalidRole(): void
+    {
+        $user = $this->createUser(Role::PROF);
+        $this->userRepository->save($user);
+
+        $this->expectException(InvalidArgumentException::class);
+
+        ($this->handler)(new UpdateUserRolesCommand(
+            userId: (string) $user->id,
+            roles: ['ROLE_INVALID'],
+        ));
+    }
+
+    private function createUser(Role $role): User
+    {
+        return User::creer(
+            email: new Email('user@example.com'),
+            role: $role,
+            tenantId: TenantId::fromString(self::TENANT_ID),
+            schoolName: 'École Alpha',
+            dateNaissance: null,
+            createdAt: new DateTimeImmutable('2026-01-15 10:00:00'),
+        );
+    }
+}
--- a/backend/tests/Unit/Administration/Application/Service/RoleContextTest.php
+++ b/backend/tests/Unit/Administration/Application/Service/RoleContextTest.php
@@ -0,0 +1,139 @@
+<?php
+
+declare(strict_types=1);
+
+namespace App\Tests\Unit\Administration\Application\Service;
+
+use App\Administration\Application\Port\ActiveRoleStore;
+use App\Administration\Application\Service\RoleContext;
+use App\Administration\Domain\Exception\RoleNonAttribueException;
+use App\Administration\Domain\Model\User\Email;
+use App\Administration\Domain\Model\User\Role;
+use App\Administration\Domain\Model\User\StatutCompte;
+use App\Administration\Domain\Model\User\User;
+use App\Administration\Domain\Model\User\UserId;
+use App\Shared\Domain\Tenant\TenantId;
+use DateTimeImmutable;
+use DomainException;
+use PHPUnit\Framework\Attributes\Test;
+use PHPUnit\Framework\TestCase;
+
+final class RoleContextTest extends TestCase
+{
+    private const string TENANT_ID = '550e8400-e29b-41d4-a716-446655440002';
+
+    private InMemoryActiveRoleStore $store;
+    private RoleContext $roleContext;
+
+    protected function setUp(): void
+    {
+        $this->store = new InMemoryActiveRoleStore();
+        $this->roleContext = new RoleContext($this->store);
+    }
+
+    #[Test]
+    public function itReturnsPrimaryRoleWhenNoActiveRoleStored(): void
+    {
+        $user = $this->createUser(Role::PROF);
+
+        self::assertSame(Role::PROF, $this->roleContext->getActiveRole($user));
+    }
+
+    #[Test]
+    public function itSwitchesToAnotherRole(): void
+    {
+        $user = $this->createActiveUser(Role::PROF);
+        $user->attribuerRole(Role::ADMIN, new DateTimeImmutable());
+
+        $this->roleContext->switchTo($user, Role::ADMIN);
+
+        self::assertSame(Role::ADMIN, $this->roleContext->getActiveRole($user));
+    }
+
+    #[Test]
+    public function itThrowsWhenSwitchingToUnassignedRole(): void
+    {
+        $user = $this->createActiveUser(Role::PROF);
+
+        $this->expectException(RoleNonAttribueException::class);
+
+        $this->roleContext->switchTo($user, Role::ADMIN);
+    }
+
+    #[Test]
+    public function itClearsActiveRole(): void
+    {
+        $user = $this->createActiveUser(Role::PROF);
+        $user->attribuerRole(Role::ADMIN, new DateTimeImmutable());
+
+        $this->roleContext->switchTo($user, Role::ADMIN);
+        $this->roleContext->clear($user);
+
+        self::assertSame(Role::PROF, $this->roleContext->getActiveRole($user));
+    }
+
+    #[Test]
+    public function itThrowsWhenAccountIsNotActive(): void
+    {
+        $user = $this->createActiveUser(Role::PROF);
+        $user->attribuerRole(Role::ADMIN, new DateTimeImmutable());
+        $user->bloquer('Test', new DateTimeImmutable());
+
+        $this->expectException(DomainException::class);
+
+        $this->roleContext->switchTo($user, Role::ADMIN);
+    }
+
+    private function createUser(Role $role): User
+    {
+        return User::creer(
+            email: new Email('user@example.com'),
+            role: $role,
+            tenantId: TenantId::fromString(self::TENANT_ID),
+            schoolName: 'École Test',
+            dateNaissance: null,
+            createdAt: new DateTimeImmutable('2026-01-15 10:00:00'),
+        );
+    }
+
+    private function createActiveUser(Role $role): User
+    {
+        return User::reconstitute(
+            id: UserId::generate(),
+            email: new Email('active@example.com'),
+            roles: [$role],
+            tenantId: TenantId::fromString(self::TENANT_ID),
+            schoolName: 'École Test',
+            statut: StatutCompte::ACTIF,
+            dateNaissance: null,
+            createdAt: new DateTimeImmutable('2026-01-15 10:00:00'),
+            hashedPassword: 'hashed',
+            activatedAt: new DateTimeImmutable('2026-01-16 10:00:00'),
+            consentementParental: null,
+        );
+    }
+}
+
+/**
+ * @internal
+ */
+final class InMemoryActiveRoleStore implements ActiveRoleStore
+{
+    /** @var array<string, Role> */
+    private array $roles = [];
+
+    public function store(User $user, Role $role): void
+    {
+        $this->roles[(string) $user->id] = $role;
+    }
+
+    public function get(User $user): ?Role
+    {
+        return $this->roles[(string) $user->id] ?? null;
+    }
+
+    public function clear(User $user): void
+    {
+        unset($this->roles[(string) $user->id]);
+    }
+}