feat: Avertir l'enseignant quand un devoir ne respecte pas les règles (mode soft)

Quand un établissement configure des règles de devoirs en mode "soft", l'enseignant est maintenant averti avant la création si la date d'échéance ne respecte pas les contraintes (délai minimum, pas de lundi après un certain créneau). Il peut alors choisir de continuer (avec traçabilité) ou de modifier la date vers une date conforme. Le mode "hard" (blocage) reste protégé : acknowledgeWarning ne permet pas de contourner les règles bloquantes, préparant la story 5.5.
2026-03-18 16:37:16 +01:00
parent 706ec43473
commit c46d053db7
17 changed files with 1223 additions and 11 deletions
--- a/backend/src/Scolarite/Application/Command/CreateHomework/CreateHomeworkCommand.php
+++ b/backend/src/Scolarite/Application/Command/CreateHomework/CreateHomeworkCommand.php
@@ -14,6 +14,7 @@ final readonly class CreateHomeworkCommand
        public string $title,
        public ?string $description,
        public string $dueDate,
+        public bool $acknowledgeWarning = false,
    ) {
    }
 }
--- a/backend/src/Scolarite/Application/Command/CreateHomework/CreateHomeworkHandler.php
+++ b/backend/src/Scolarite/Application/Command/CreateHomework/CreateHomeworkHandler.php
@@ -9,7 +9,9 @@ use App\Administration\Domain\Model\Subject\SubjectId;
 use App\Administration\Domain\Model\User\UserId;
 use App\Scolarite\Application\Port\CurrentCalendarProvider;
 use App\Scolarite\Application\Port\EnseignantAffectationChecker;
+use App\Scolarite\Application\Port\HomeworkRulesChecker;
 use App\Scolarite\Domain\Exception\EnseignantNonAffecteException;
+use App\Scolarite\Domain\Exception\ReglesDevoirsNonRespecteesException;
 use App\Scolarite\Domain\Model\Homework\Homework;
 use App\Scolarite\Domain\Repository\HomeworkRepository;
 use App\Scolarite\Domain\Service\DueDateValidator;
@@ -26,6 +28,7 @@ final readonly class CreateHomeworkHandler
        private EnseignantAffectationChecker $affectationChecker,
        private CurrentCalendarProvider $calendarProvider,
        private DueDateValidator $dueDateValidator,
+        private HomeworkRulesChecker $rulesChecker,
        private Clock $clock,
    ) {
    }
@@ -46,6 +49,16 @@ final readonly class CreateHomeworkHandler
        $dueDate = new DateTimeImmutable($command->dueDate);
        $this->dueDateValidator->valider($dueDate, $now, $calendar);

+        $rulesResult = $this->rulesChecker->verifier($tenantId, $dueDate, $now);
+
+        if ($rulesResult->estBloquant()) {
+            throw new ReglesDevoirsNonRespecteesException($rulesResult->toArray());
+        }
+
+        if ($rulesResult->estAvertissement() && !$command->acknowledgeWarning) {
+            throw new ReglesDevoirsNonRespecteesException($rulesResult->toArray());
+        }
+
        $homework = Homework::creer(
            tenantId: $tenantId,
            classId: $classId,
@@ -57,6 +70,10 @@ final readonly class CreateHomeworkHandler
            now: $now,
        );

+        if ($command->acknowledgeWarning && $rulesResult->estAvertissement()) {
+            $homework->acknowledgeRuleWarning($rulesResult->ruleTypes(), $now);
+        }
+
        $this->homeworkRepository->save($homework);

        return $homework;
--- a/backend/src/Scolarite/Application/Port/HomeworkRulesCheckResult.php
+++ b/backend/src/Scolarite/Application/Port/HomeworkRulesCheckResult.php
@@ -0,0 +1,79 @@
+<?php
+
+declare(strict_types=1);
+
+namespace App\Scolarite\Application\Port;
+
+use function array_map;
+use function count;
+
+/**
+ * Résultat de la vérification des règles de devoirs.
+ *
+ * Transporté à travers la frontière Scolarite ← Administration,
+ * indépendant des types internes d'Administration.
+ */
+final readonly class HomeworkRulesCheckResult
+{
+    /**
+     * @param RuleWarning[] $warnings
+     */
+    public function __construct(
+        public array $warnings,
+        public bool $bloquant,
+    ) {
+    }
+
+    public function estValide(): bool
+    {
+        return count($this->warnings) === 0;
+    }
+
+    public function estAvertissement(): bool
+    {
+        return !$this->estValide() && !$this->bloquant;
+    }
+
+    public function estBloquant(): bool
+    {
+        return !$this->estValide() && $this->bloquant;
+    }
+
+    /**
+     * @return string[]
+     */
+    public function messages(): array
+    {
+        return array_map(
+            static fn (RuleWarning $w): string => $w->message,
+            $this->warnings,
+        );
+    }
+
+    /**
+     * @return string[]
+     */
+    public function ruleTypes(): array
+    {
+        return array_map(
+            static fn (RuleWarning $w): string => $w->ruleType,
+            $this->warnings,
+        );
+    }
+
+    /**
+     * @return array<array{ruleType: string, message: string, params: array<string, mixed>}>
+     */
+    public function toArray(): array
+    {
+        return array_map(
+            static fn (RuleWarning $w): array => $w->toArray(),
+            $this->warnings,
+        );
+    }
+
+    public static function ok(): self
+    {
+        return new self(warnings: [], bloquant: false);
+    }
+}
--- a/backend/src/Scolarite/Application/Port/HomeworkRulesChecker.php
+++ b/backend/src/Scolarite/Application/Port/HomeworkRulesChecker.php
@@ -0,0 +1,23 @@
+<?php
+
+declare(strict_types=1);
+
+namespace App\Scolarite\Application\Port;
+
+use App\Shared\Domain\Tenant\TenantId;
+use DateTimeImmutable;
+
+/**
+ * Port pour vérifier les règles de devoirs configurées par l'établissement.
+ *
+ * L'implémentation consulte la configuration des règles du tenant
+ * et retourne le résultat de validation.
+ */
+interface HomeworkRulesChecker
+{
+    public function verifier(
+        TenantId $tenantId,
+        DateTimeImmutable $dueDate,
+        DateTimeImmutable $creationDate,
+    ): HomeworkRulesCheckResult;
+}
--- a/backend/src/Scolarite/Application/Port/RuleWarning.php
+++ b/backend/src/Scolarite/Application/Port/RuleWarning.php
@@ -0,0 +1,33 @@
+<?php
+
+declare(strict_types=1);
+
+namespace App\Scolarite\Application\Port;
+
+/**
+ * Avertissement d'une règle de devoir non respectée.
+ */
+final readonly class RuleWarning
+{
+    /**
+     * @param array<string, mixed> $params Paramètres de la règle pour le frontend
+     */
+    public function __construct(
+        public string $ruleType,
+        public string $message,
+        public array $params = [],
+    ) {
+    }
+
+    /**
+     * @return array{ruleType: string, message: string, params: array<string, mixed>}
+     */
+    public function toArray(): array
+    {
+        return [
+            'ruleType' => $this->ruleType,
+            'message' => $this->message,
+            'params' => $this->params,
+        ];
+    }
+}
--- a/backend/src/Scolarite/Domain/Exception/ReglesDevoirsNonRespecteesException.php
+++ b/backend/src/Scolarite/Domain/Exception/ReglesDevoirsNonRespecteesException.php
@@ -0,0 +1,23 @@
+<?php
+
+declare(strict_types=1);
+
+namespace App\Scolarite\Domain\Exception;
+
+use DomainException;
+
+/**
+ * Levée quand un devoir enfreint les règles configurées
+ * et que l'enseignant n'a pas encore confirmé.
+ */
+final class ReglesDevoirsNonRespecteesException extends DomainException
+{
+    /**
+     * @param array<array{ruleType: string, message: string, params: array<string, mixed>}> $warnings
+     */
+    public function __construct(
+        public readonly array $warnings,
+    ) {
+        parent::__construct('Le devoir ne respecte pas les règles configurées.');
+    }
+}
--- a/backend/src/Scolarite/Domain/Model/Homework/Homework.php
+++ b/backend/src/Scolarite/Domain/Model/Homework/Homework.php
@@ -19,6 +19,9 @@ final class Homework extends AggregateRoot
 {
    public private(set) DateTimeImmutable $updatedAt;

+    /** @var array{warnings: string[], acknowledgedAt: string}|null */
+    public private(set) ?array $ruleOverride = null;
+
    private function __construct(
        public private(set) HomeworkId $id,
        public private(set) TenantId $tenantId,
@@ -34,6 +37,17 @@ final class Homework extends AggregateRoot
        $this->updatedAt = $createdAt;
    }

+    /**
+     * @param string[] $ruleTypes Types de règles contournées (ex: ['minimum_delay'])
+     */
+    public function acknowledgeRuleWarning(array $ruleTypes, DateTimeImmutable $now): void
+    {
+        $this->ruleOverride = [
+            'warnings' => $ruleTypes,
+            'acknowledgedAt' => $now->format(DateTimeImmutable::ATOM),
+        ];
+    }
+
    public static function creer(
        TenantId $tenantId,
        ClassId $classId,
@@ -110,6 +124,8 @@ final class Homework extends AggregateRoot

    /**
     * @internal Pour usage Infrastructure uniquement
+     *
+     * @param array{warnings: string[], acknowledgedAt: string}|null $ruleOverride
     */
    public static function reconstitute(
        HomeworkId $id,
@@ -123,6 +139,7 @@ final class Homework extends AggregateRoot
        HomeworkStatus $status,
        DateTimeImmutable $createdAt,
        DateTimeImmutable $updatedAt,
+        ?array $ruleOverride = null,
    ): self {
        $homework = new self(
            id: $id,
@@ -138,6 +155,7 @@ final class Homework extends AggregateRoot
        );

        $homework->updatedAt = $updatedAt;
+        $homework->ruleOverride = $ruleOverride;

        return $homework;
    }
--- a/backend/src/Scolarite/Infrastructure/Api/Processor/CreateHomeworkProcessor.php
+++ b/backend/src/Scolarite/Infrastructure/Api/Processor/CreateHomeworkProcessor.php
@@ -11,11 +11,14 @@ use App\Scolarite\Application\Command\CreateHomework\CreateHomeworkCommand;
 use App\Scolarite\Application\Command\CreateHomework\CreateHomeworkHandler;
 use App\Scolarite\Domain\Exception\DateEcheanceInvalideException;
 use App\Scolarite\Domain\Exception\EnseignantNonAffecteException;
+use App\Scolarite\Domain\Exception\ReglesDevoirsNonRespecteesException;
 use App\Scolarite\Infrastructure\Api\Resource\HomeworkResource;
 use App\Shared\Infrastructure\Tenant\TenantContext;
 use Override;
 use Ramsey\Uuid\Exception\InvalidUuidStringException;
 use Symfony\Bundle\SecurityBundle\Security;
+use Symfony\Component\HttpFoundation\JsonResponse;
+use Symfony\Component\HttpFoundation\Response;
 use Symfony\Component\HttpKernel\Exception\BadRequestHttpException;
 use Symfony\Component\HttpKernel\Exception\UnauthorizedHttpException;
 use Symfony\Component\Messenger\MessageBusInterface;
@@ -37,7 +40,7 @@ final readonly class CreateHomeworkProcessor implements ProcessorInterface
     * @param HomeworkResource $data
     */
    #[Override]
-    public function process(mixed $data, Operation $operation, array $uriVariables = [], array $context = []): HomeworkResource
+    public function process(mixed $data, Operation $operation, array $uriVariables = [], array $context = []): HomeworkResource|JsonResponse
    {
        if (!$this->tenantContext->hasTenant()) {
            throw new UnauthorizedHttpException('Bearer', 'Tenant non défini.');
@@ -58,6 +61,7 @@ final readonly class CreateHomeworkProcessor implements ProcessorInterface
                title: $data->title ?? '',
                description: $data->description,
                dueDate: $data->dueDate ?? '',
+                acknowledgeWarning: $data->acknowledgeWarning ?? false,
            );

            $homework = ($this->handler)($command);
@@ -67,6 +71,12 @@ final readonly class CreateHomeworkProcessor implements ProcessorInterface
            }

            return HomeworkResource::fromDomain($homework);
+        } catch (ReglesDevoirsNonRespecteesException $e) {
+            return new JsonResponse([
+                'type' => 'homework_rules_warning',
+                'message' => $e->getMessage(),
+                'warnings' => $e->warnings,
+            ], Response::HTTP_CONFLICT);
        } catch (EnseignantNonAffecteException|DateEcheanceInvalideException $e) {
            throw new BadRequestHttpException($e->getMessage());
        } catch (InvalidUuidStringException $e) {
--- a/backend/src/Scolarite/Infrastructure/Api/Resource/HomeworkResource.php
+++ b/backend/src/Scolarite/Infrastructure/Api/Resource/HomeworkResource.php
@@ -80,6 +80,8 @@ final class HomeworkResource

    public ?string $status = null;

+    public ?bool $acknowledgeWarning = null;
+
    public ?string $className = null;

    public ?string $subjectName = null;
@@ -88,6 +90,8 @@ final class HomeworkResource

    public ?DateTimeImmutable $updatedAt = null;

+    public ?bool $hasRuleOverride = null;
+
    public static function fromDomain(
        Homework $homework,
        ?string $className = null,
@@ -106,6 +110,7 @@ final class HomeworkResource
        $resource->subjectName = $subjectName;
        $resource->createdAt = $homework->createdAt;
        $resource->updatedAt = $homework->updatedAt;
+        $resource->hasRuleOverride = $homework->ruleOverride !== null;

        return $resource;
    }
--- a/backend/src/Scolarite/Infrastructure/Persistence/Doctrine/DoctrineHomeworkRepository.php
+++ b/backend/src/Scolarite/Infrastructure/Persistence/Doctrine/DoctrineHomeworkRepository.php
@@ -18,6 +18,13 @@ use function array_map;

 use DateTimeImmutable;
 use Doctrine\DBAL\Connection;
+
+use function is_string;
+use function json_decode;
+use function json_encode;
+
+use const JSON_THROW_ON_ERROR;
+
 use Override;

 final readonly class DoctrineHomeworkRepository implements HomeworkRepository
@@ -31,13 +38,14 @@ final readonly class DoctrineHomeworkRepository implements HomeworkRepository
    public function save(Homework $homework): void
    {
        $this->connection->executeStatement(
-            'INSERT INTO homework (id, tenant_id, class_id, subject_id, teacher_id, title, description, due_date, status, created_at, updated_at)
-             VALUES (:id, :tenant_id, :class_id, :subject_id, :teacher_id, :title, :description, :due_date, :status, :created_at, :updated_at)
+            'INSERT INTO homework (id, tenant_id, class_id, subject_id, teacher_id, title, description, due_date, status, rule_override, created_at, updated_at)
+             VALUES (:id, :tenant_id, :class_id, :subject_id, :teacher_id, :title, :description, :due_date, :status, :rule_override, :created_at, :updated_at)
             ON CONFLICT (id) DO UPDATE SET
                 title = EXCLUDED.title,
                 description = EXCLUDED.description,
                 due_date = EXCLUDED.due_date,
                 status = EXCLUDED.status,
+                 rule_override = EXCLUDED.rule_override,
                 updated_at = EXCLUDED.updated_at',
            [
                'id' => (string) $homework->id,
@@ -49,6 +57,7 @@ final readonly class DoctrineHomeworkRepository implements HomeworkRepository
                'description' => $homework->description,
                'due_date' => $homework->dueDate->format('Y-m-d'),
                'status' => $homework->status->value,
+                'rule_override' => $homework->ruleOverride !== null ? json_encode($homework->ruleOverride, JSON_THROW_ON_ERROR) : null,
                'created_at' => $homework->createdAt->format(DateTimeImmutable::ATOM),
                'updated_at' => $homework->updatedAt->format(DateTimeImmutable::ATOM),
            ],
@@ -154,6 +163,13 @@ final readonly class DoctrineHomeworkRepository implements HomeworkRepository
        $createdAt = $row['created_at'];
        /** @var string $updatedAt */
        $updatedAt = $row['updated_at'];
+        /** @var string|null $ruleOverrideJson */
+        $ruleOverrideJson = $row['rule_override'] ?? null;
+
+        /** @var array{warnings: string[], acknowledgedAt: string}|null $ruleOverride */
+        $ruleOverride = is_string($ruleOverrideJson)
+            ? json_decode($ruleOverrideJson, true, 512, JSON_THROW_ON_ERROR)
+            : null;

        return Homework::reconstitute(
            id: HomeworkId::fromString($id),
@@ -167,6 +183,7 @@ final readonly class DoctrineHomeworkRepository implements HomeworkRepository
            status: HomeworkStatus::from($status),
            createdAt: new DateTimeImmutable($createdAt),
            updatedAt: new DateTimeImmutable($updatedAt),
+            ruleOverride: $ruleOverride,
        );
    }
 }
--- a/backend/src/Scolarite/Infrastructure/Service/AdministrationHomeworkRulesChecker.php
+++ b/backend/src/Scolarite/Infrastructure/Service/AdministrationHomeworkRulesChecker.php
@@ -0,0 +1,80 @@
+<?php
+
+declare(strict_types=1);
+
+namespace App\Scolarite\Infrastructure\Service;
+
+use App\Administration\Application\Service\HomeworkRulesValidationResult;
+use App\Administration\Application\Service\HomeworkRulesValidator;
+use App\Administration\Application\Service\RuleViolation;
+use App\Administration\Domain\Model\HomeworkRules\HomeworkRule;
+use App\Administration\Domain\Model\HomeworkRules\HomeworkRules;
+use App\Administration\Domain\Repository\HomeworkRulesRepository;
+use App\Scolarite\Application\Port\HomeworkRulesChecker;
+use App\Scolarite\Application\Port\HomeworkRulesCheckResult;
+use App\Scolarite\Application\Port\RuleWarning;
+use App\Shared\Domain\Tenant\TenantId;
+
+use function array_map;
+
+use DateTimeImmutable;
+use Override;
+
+/**
+ * Adaptateur qui délègue la vérification des règles au bounded context Administration.
+ */
+final readonly class AdministrationHomeworkRulesChecker implements HomeworkRulesChecker
+{
+    public function __construct(
+        private HomeworkRulesRepository $rulesRepository,
+        private HomeworkRulesValidator $validator,
+    ) {
+    }
+
+    #[Override]
+    public function verifier(
+        TenantId $tenantId,
+        DateTimeImmutable $dueDate,
+        DateTimeImmutable $creationDate,
+    ): HomeworkRulesCheckResult {
+        $rules = $this->rulesRepository->findByTenantId($tenantId);
+
+        if ($rules === null) {
+            return HomeworkRulesCheckResult::ok();
+        }
+
+        $result = $this->validator->valider($rules, $dueDate, $creationDate);
+
+        return $this->toCheckResult($result, $rules);
+    }
+
+    private function toCheckResult(HomeworkRulesValidationResult $result, HomeworkRules $rules): HomeworkRulesCheckResult
+    {
+        return new HomeworkRulesCheckResult(
+            warnings: array_map(
+                fn (RuleViolation $v): RuleWarning => new RuleWarning(
+                    ruleType: $v->ruleType->value,
+                    message: $v->message,
+                    params: $this->findRuleParams($rules, $v),
+                ),
+                $result->violations,
+            ),
+            bloquant: $result->estBloquant(),
+        );
+    }
+
+    /**
+     * @return array<string, mixed>
+     */
+    private function findRuleParams(HomeworkRules $rules, RuleViolation $violation): array
+    {
+        foreach ($rules->rules as $rule) {
+            /** @var HomeworkRule $rule */
+            if ($rule->type === $violation->ruleType) {
+                return $rule->params;
+            }
+        }
+
+        return [];
+    }
+}