feat: Afficher les statistiques de notes par matière côté administration
L'admin doit pouvoir voir en un coup d'œil quelles matières sont actives (notes saisies) pour décider lesquelles peuvent être supprimées sans perte de données. Auparavant, la suppression d'une matière était silencieuse : elle cascade-deletait évaluations et notes sans avertir. La liste des matières affiche désormais les compteurs d'enseignants, classes, évaluations et notes. La suppression déclenche une confirmation explicite quand la matière contient des notes, avec récapitulatif des volumes impactés, pour rendre l'action irréversible consciente. Côté tests, un endpoint de seeding HTTP remplace les appels docker exec dans les E2E (gain ~30-60s → 5-10s par test), et un trait partagé factorise le SQL de seeding entre les deux suites fonctionnelles.
This commit is contained in:
@@ -456,21 +456,95 @@ test.describe('Subjects Management (Story 2.2)', () => {
|
||||
// AC3: Deletion with warning for subjects with grades
|
||||
// ============================================================================
|
||||
test.describe('AC3: Deletion with warning for grades', () => {
|
||||
// SKIP REASON: The Grades module is not yet implemented.
|
||||
// HasGradesForSubjectHandler currently returns false (stub), so all subjects
|
||||
// appear without grades and can be deleted without warning. This test will
|
||||
// be enabled once the Grades module allows recording grades for subjects.
|
||||
//
|
||||
// When enabled, this test should:
|
||||
// 1. Create a subject
|
||||
// 2. Add at least one grade to it
|
||||
// 3. Attempt to delete the subject
|
||||
// 4. Verify the warning message about grades
|
||||
// 5. Require explicit confirmation
|
||||
test.skip('shows warning when trying to delete subject with grades', async ({ page }) => {
|
||||
// Subjects seeded by tests in this describe — nettoyés en afterAll via
|
||||
// l'endpoint DELETE /test/seed/subject-with-grades/{subjectId} qui purge
|
||||
// les évaluations et notes associées (le subject lui-même étant soft-deleté
|
||||
// par le flow normal via la modale).
|
||||
const seededSubjectIds: string[] = [];
|
||||
|
||||
// Helper to extract UUIDs from `dbal:run-sql` output — garde pour le
|
||||
// `subjectId` créé par l'UI (une seule requête par test vs. 4 auparavant).
|
||||
function firstUuidFromSql(sql: string): string | null {
|
||||
const output = execSync(
|
||||
`docker compose -f "${composeFile}" exec -T php php bin/console dbal:run-sql "${sql}" 2>&1`,
|
||||
{ encoding: 'utf-8' }
|
||||
);
|
||||
const match = output.match(/[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}/);
|
||||
return match ? match[0] : null;
|
||||
}
|
||||
|
||||
test.afterAll(async ({ request }) => {
|
||||
for (const subjectId of seededSubjectIds) {
|
||||
try {
|
||||
await request.delete(`${ALPHA_URL}/test/seed/subject-with-grades/${subjectId}`);
|
||||
} catch {
|
||||
// Best-effort : l'absence de cleanup ne doit pas faire échouer la suite.
|
||||
}
|
||||
}
|
||||
seededSubjectIds.length = 0;
|
||||
});
|
||||
|
||||
test('shows impact warning with evaluation and grade counts before deletion', async ({
|
||||
page
|
||||
}) => {
|
||||
await loginAsAdmin(page);
|
||||
await page.goto(`${ALPHA_URL}/admin/subjects`);
|
||||
// Implementation pending Grades module
|
||||
|
||||
// Create a subject for which we will seed evaluations/grades
|
||||
await openNewSubjectDialog(page);
|
||||
const subjectName = `WithGrades-${Date.now()}`;
|
||||
const subjectCode = `WG${Date.now() % 10000}`;
|
||||
await page.locator('#subject-name').fill(subjectName);
|
||||
await page.locator('#subject-code').fill(subjectCode);
|
||||
await page.getByRole('button', { name: /créer la matière/i }).click();
|
||||
await expect(page.getByRole('dialog')).not.toBeVisible({ timeout: 10000 });
|
||||
|
||||
const subjectId = firstUuidFromSql(
|
||||
`SELECT id FROM subjects WHERE tenant_id = '${TENANT_ID}' AND code = '${subjectCode.toUpperCase()}' LIMIT 1`
|
||||
);
|
||||
if (!subjectId) {
|
||||
throw new Error('Failed to resolve subjectId');
|
||||
}
|
||||
seededSubjectIds.push(subjectId);
|
||||
|
||||
// Seed classe + 2 évaluations + 2 notes en UN appel HTTP au lieu de 6+
|
||||
// `docker exec dbal:run-sql`. Gain : ~30-60 s → ~5-10 s par test.
|
||||
const seedResponse = await page.request.post(
|
||||
`${ALPHA_URL}/test/seed/subject-with-grades`,
|
||||
{
|
||||
data: {
|
||||
subjectId,
|
||||
teacherEmail: ADMIN_EMAIL,
|
||||
evaluationCount: 2,
|
||||
gradesPerEval: 1
|
||||
}
|
||||
}
|
||||
);
|
||||
if (!seedResponse.ok()) {
|
||||
throw new Error(
|
||||
`Seed endpoint failed: ${seedResponse.status()} ${await seedResponse.text()}`
|
||||
);
|
||||
}
|
||||
|
||||
clearCache();
|
||||
await page.reload();
|
||||
|
||||
const subjectCard = page.locator('.subject-card', { hasText: subjectName });
|
||||
await subjectCard.getByRole('button', { name: /supprimer/i }).click();
|
||||
|
||||
const deleteModal = page.getByRole('alertdialog');
|
||||
await expect(deleteModal).toBeVisible({ timeout: 10000 });
|
||||
|
||||
const impact = deleteModal.getByTestId('delete-subject-impact');
|
||||
await expect(impact).toBeVisible();
|
||||
|
||||
// AC1 exact wording: "X évaluations et Y notes seront affectées"
|
||||
const summary = deleteModal.getByTestId('delete-subject-impact-summary');
|
||||
await expect(summary).toHaveText(/2 évaluations et 2 notes seront affectées\./);
|
||||
|
||||
await deleteModal.getByRole('button', { name: /supprimer/i }).click();
|
||||
await expect(deleteModal).not.toBeVisible({ timeout: 10000 });
|
||||
await expect(page.getByText(subjectName)).not.toBeVisible({ timeout: 10000 });
|
||||
});
|
||||
});
|
||||
|
||||
|
||||
Reference in New Issue
Block a user