feat: Permettre à l'élève de consulter ses notes et moyennes
Some checks failed
CI / Backend Tests (push) Has been cancelled
CI / Frontend Tests (push) Has been cancelled
CI / E2E Tests (push) Has been cancelled
CI / Naming Conventions (push) Has been cancelled
CI / Build Check (push) Has been cancelled

L'élève avait accès à ses compétences mais pas à ses notes numériques.
Cette fonctionnalité lui donne une vue complète de sa progression scolaire
avec moyennes par matière, détail par évaluation, statistiques de classe,
et un mode "découverte" pour révéler ses notes à son rythme (FR14, FR15).

Les notes ne sont visibles qu'après publication par l'enseignant, ce qui
garantit que l'élève les découvre avant ses parents (délai 24h story 6.7).
This commit is contained in:
2026-04-05 16:04:26 +02:00
parent b7dc27f2a5
commit 272d31e1c0
59 changed files with 7057 additions and 49 deletions

View File

@@ -0,0 +1,347 @@
<?php
declare(strict_types=1);
namespace App\Tests\Unit\Scolarite\Infrastructure\Api\Provider;
use ApiPlatform\Metadata\Get;
use App\Administration\Domain\Model\Subject\SubjectId;
use App\Administration\Domain\Model\User\UserId;
use App\Administration\Infrastructure\Security\SecurityUser;
use App\Scolarite\Application\Port\PeriodFinder;
use App\Scolarite\Application\Port\PeriodInfo;
use App\Scolarite\Infrastructure\Api\Provider\StudentMyAveragesProvider;
use App\Scolarite\Infrastructure\Api\Resource\StudentMyAveragesResource;
use App\Scolarite\Infrastructure\Persistence\InMemory\InMemoryStudentAverageRepository;
use App\Shared\Domain\Tenant\TenantId;
use App\Shared\Infrastructure\Tenant\TenantConfig;
use App\Shared\Infrastructure\Tenant\TenantContext;
use App\Shared\Infrastructure\Tenant\TenantId as InfraTenantId;
use DateTimeImmutable;
use PHPUnit\Framework\Attributes\Test;
use PHPUnit\Framework\TestCase;
use Symfony\Bundle\SecurityBundle\Security;
use Symfony\Component\HttpKernel\Exception\AccessDeniedHttpException;
use Symfony\Component\HttpKernel\Exception\UnauthorizedHttpException;
final class StudentMyAveragesProviderTest extends TestCase
{
private const string TENANT_UUID = 'a1b2c3d4-e5f6-7890-abcd-ef1234567890';
private const string STUDENT_UUID = '22222222-2222-2222-2222-222222222222';
private const string SUBJECT_UUID = '66666666-6666-6666-6666-666666666666';
private const string PERIOD_ID = '11111111-1111-1111-1111-111111111111';
private InMemoryStudentAverageRepository $averageRepository;
private TenantContext $tenantContext;
protected function setUp(): void
{
$this->averageRepository = new InMemoryStudentAverageRepository();
$this->tenantContext = new TenantContext();
}
// =========================================================================
// Auth & Tenant Guards
// =========================================================================
#[Test]
public function itRejects401WhenNoTenant(): void
{
$provider = $this->createProvider(
user: $this->studentUser(),
periodForDate: null,
);
$this->expectException(UnauthorizedHttpException::class);
$provider->provide(new Get());
}
#[Test]
public function itRejects401WhenNoUser(): void
{
$this->setTenant();
$provider = $this->createProvider(
user: null,
periodForDate: null,
);
$this->expectException(UnauthorizedHttpException::class);
$provider->provide(new Get());
}
#[Test]
public function itRejects403ForTeacher(): void
{
$this->setTenant();
$provider = $this->createProvider(
user: $this->teacherUser(),
periodForDate: null,
);
$this->expectException(AccessDeniedHttpException::class);
$provider->provide(new Get());
}
#[Test]
public function itRejects403ForParent(): void
{
$this->setTenant();
$provider = $this->createProvider(
user: $this->parentUser(),
periodForDate: null,
);
$this->expectException(AccessDeniedHttpException::class);
$provider->provide(new Get());
}
#[Test]
public function itRejects403ForAdmin(): void
{
$this->setTenant();
$provider = $this->createProvider(
user: $this->adminUser(),
periodForDate: null,
);
$this->expectException(AccessDeniedHttpException::class);
$provider->provide(new Get());
}
// =========================================================================
// Period auto-detection
// =========================================================================
#[Test]
public function itAutoDetectsCurrentPeriodWhenNoPeriodIdInFilters(): void
{
$this->setTenant();
$this->seedAverages();
$provider = $this->createProvider(
user: $this->studentUser(),
periodForDate: new PeriodInfo(self::PERIOD_ID, new DateTimeImmutable('2026-01-01'), new DateTimeImmutable('2026-03-31')),
);
$result = $provider->provide(new Get());
self::assertInstanceOf(StudentMyAveragesResource::class, $result);
self::assertSame(self::PERIOD_ID, $result->periodId);
self::assertNotEmpty($result->subjectAverages);
self::assertSame(16.0, $result->generalAverage);
}
#[Test]
public function itReturnsEmptyResourceWhenNoPeriodDetected(): void
{
$this->setTenant();
$this->seedAverages();
$provider = $this->createProvider(
user: $this->studentUser(),
periodForDate: null,
);
$result = $provider->provide(new Get());
self::assertInstanceOf(StudentMyAveragesResource::class, $result);
self::assertNull($result->periodId);
self::assertEmpty($result->subjectAverages);
self::assertNull($result->generalAverage);
}
// =========================================================================
// Explicit periodId from filters
// =========================================================================
#[Test]
public function itUsesExplicitPeriodIdFromFilters(): void
{
$this->setTenant();
$this->seedAverages();
$provider = $this->createProvider(
user: $this->studentUser(),
periodForDate: null,
);
$result = $provider->provide(new Get(), [], [
'filters' => ['periodId' => self::PERIOD_ID],
]);
self::assertInstanceOf(StudentMyAveragesResource::class, $result);
self::assertSame(self::PERIOD_ID, $result->periodId);
self::assertNotEmpty($result->subjectAverages);
}
#[Test]
public function itReturnsEmptySubjectAveragesForUnknownPeriod(): void
{
$this->setTenant();
$this->seedAverages();
$unknownPeriod = '99999999-9999-9999-9999-999999999999';
$provider = $this->createProvider(
user: $this->studentUser(),
periodForDate: null,
);
$result = $provider->provide(new Get(), [], [
'filters' => ['periodId' => $unknownPeriod],
]);
self::assertInstanceOf(StudentMyAveragesResource::class, $result);
self::assertSame($unknownPeriod, $result->periodId);
self::assertEmpty($result->subjectAverages);
self::assertNull($result->generalAverage);
}
// =========================================================================
// Response shape
// =========================================================================
#[Test]
public function itReturnsStudentIdInResource(): void
{
$this->setTenant();
$provider = $this->createProvider(
user: $this->studentUser(),
periodForDate: null,
);
$result = $provider->provide(new Get(), [], [
'filters' => ['periodId' => self::PERIOD_ID],
]);
self::assertInstanceOf(StudentMyAveragesResource::class, $result);
self::assertSame(self::STUDENT_UUID, $result->studentId);
}
#[Test]
public function itReturnsSubjectAverageShape(): void
{
$this->setTenant();
$this->seedAverages();
$provider = $this->createProvider(
user: $this->studentUser(),
periodForDate: null,
);
$result = $provider->provide(new Get(), [], [
'filters' => ['periodId' => self::PERIOD_ID],
]);
self::assertInstanceOf(StudentMyAveragesResource::class, $result);
self::assertCount(1, $result->subjectAverages);
$avg = $result->subjectAverages[0];
self::assertSame(self::SUBJECT_UUID, $avg['subjectId']);
self::assertSame(16.0, $avg['average']);
self::assertSame(1, $avg['gradeCount']);
}
// =========================================================================
// Helpers
// =========================================================================
private function setTenant(): void
{
$this->tenantContext->setCurrentTenant(new TenantConfig(
tenantId: InfraTenantId::fromString(self::TENANT_UUID),
subdomain: 'ecole-alpha',
databaseUrl: 'sqlite:///:memory:',
));
}
private function seedAverages(): void
{
$tenantId = TenantId::fromString(self::TENANT_UUID);
$studentId = UserId::fromString(self::STUDENT_UUID);
$this->averageRepository->saveSubjectAverage(
$tenantId,
$studentId,
SubjectId::fromString(self::SUBJECT_UUID),
self::PERIOD_ID,
16.0,
1,
);
$this->averageRepository->saveGeneralAverage(
$tenantId,
$studentId,
self::PERIOD_ID,
16.0,
);
}
private function createProvider(?SecurityUser $user, ?PeriodInfo $periodForDate): StudentMyAveragesProvider
{
$security = $this->createMock(Security::class);
$security->method('getUser')->willReturn($user);
$periodFinder = new class($periodForDate) implements PeriodFinder {
public function __construct(private readonly ?PeriodInfo $info)
{
}
public function findForDate(DateTimeImmutable $date, TenantId $tenantId): ?PeriodInfo
{
return $this->info;
}
};
return new StudentMyAveragesProvider(
$this->averageRepository,
$periodFinder,
$this->tenantContext,
$security,
);
}
private function studentUser(): SecurityUser
{
return new SecurityUser(
userId: UserId::fromString(self::STUDENT_UUID),
email: 'student@test.local',
hashedPassword: '',
tenantId: InfraTenantId::fromString(self::TENANT_UUID),
roles: ['ROLE_ELEVE'],
);
}
private function teacherUser(): SecurityUser
{
return new SecurityUser(
userId: UserId::fromString('44444444-4444-4444-4444-444444444444'),
email: 'teacher@test.local',
hashedPassword: '',
tenantId: InfraTenantId::fromString(self::TENANT_UUID),
roles: ['ROLE_PROF'],
);
}
private function parentUser(): SecurityUser
{
return new SecurityUser(
userId: UserId::fromString('88888888-8888-8888-8888-888888888888'),
email: 'parent@test.local',
hashedPassword: '',
tenantId: InfraTenantId::fromString(self::TENANT_UUID),
roles: ['ROLE_PARENT'],
);
}
private function adminUser(): SecurityUser
{
return new SecurityUser(
userId: UserId::fromString('33333333-3333-3333-3333-333333333333'),
email: 'admin@test.local',
hashedPassword: '',
tenantId: InfraTenantId::fromString(self::TENANT_UUID),
roles: ['ROLE_ADMIN'],
);
}
}

View File

@@ -0,0 +1,131 @@
<?php
declare(strict_types=1);
namespace App\Tests\Unit\Scolarite\Infrastructure\Persistence\InMemory;
use App\Administration\Domain\Model\User\UserId;
use App\Scolarite\Domain\Model\Evaluation\EvaluationId;
use App\Scolarite\Domain\Model\Evaluation\GradeScale;
use App\Scolarite\Domain\Model\Grade\Grade;
use App\Scolarite\Domain\Model\Grade\GradeStatus;
use App\Scolarite\Domain\Model\Grade\GradeValue;
use App\Scolarite\Infrastructure\Persistence\InMemory\InMemoryGradeRepository;
use App\Shared\Domain\Tenant\TenantId;
use DateTimeImmutable;
use PHPUnit\Framework\Attributes\Test;
use PHPUnit\Framework\TestCase;
final class InMemoryGradeRepositoryTest extends TestCase
{
private const string TENANT_ID = '550e8400-e29b-41d4-a716-446655440001';
private const string OTHER_TENANT_ID = '550e8400-e29b-41d4-a716-446655440002';
private const string EVALUATION_A_ID = '550e8400-e29b-41d4-a716-446655440010';
private const string EVALUATION_B_ID = '550e8400-e29b-41d4-a716-446655440011';
private const string EVALUATION_C_ID = '550e8400-e29b-41d4-a716-446655440012';
private const string STUDENT_ID = '550e8400-e29b-41d4-a716-446655440020';
private const string TEACHER_ID = '550e8400-e29b-41d4-a716-446655440030';
private InMemoryGradeRepository $repository;
protected function setUp(): void
{
$this->repository = new InMemoryGradeRepository();
}
#[Test]
public function findByEvaluationsReturnsGroupedResults(): void
{
$gradeA1 = $this->createGrade(self::EVALUATION_A_ID, self::TENANT_ID, 14.0);
$gradeA2 = $this->createGrade(self::EVALUATION_A_ID, self::TENANT_ID, 16.0);
$gradeB1 = $this->createGrade(self::EVALUATION_B_ID, self::TENANT_ID, 12.0);
$this->repository->save($gradeA1);
$this->repository->save($gradeA2);
$this->repository->save($gradeB1);
$result = $this->repository->findByEvaluations(
[
EvaluationId::fromString(self::EVALUATION_A_ID),
EvaluationId::fromString(self::EVALUATION_B_ID),
],
TenantId::fromString(self::TENANT_ID),
);
self::assertCount(2, $result);
self::assertArrayHasKey(self::EVALUATION_A_ID, $result);
self::assertArrayHasKey(self::EVALUATION_B_ID, $result);
self::assertCount(2, $result[self::EVALUATION_A_ID]);
self::assertCount(1, $result[self::EVALUATION_B_ID]);
}
#[Test]
public function findByEvaluationsReturnsEmptyArrayWhenNoEvaluationIds(): void
{
$grade = $this->createGrade(self::EVALUATION_A_ID, self::TENANT_ID, 14.0);
$this->repository->save($grade);
$result = $this->repository->findByEvaluations(
[],
TenantId::fromString(self::TENANT_ID),
);
self::assertSame([], $result);
}
#[Test]
public function findByEvaluationsExcludesGradesFromDifferentTenant(): void
{
$gradeOwnTenant = $this->createGrade(self::EVALUATION_A_ID, self::TENANT_ID, 14.0);
$gradeOtherTenant = $this->createGrade(self::EVALUATION_A_ID, self::OTHER_TENANT_ID, 18.0);
$this->repository->save($gradeOwnTenant);
$this->repository->save($gradeOtherTenant);
$result = $this->repository->findByEvaluations(
[EvaluationId::fromString(self::EVALUATION_A_ID)],
TenantId::fromString(self::TENANT_ID),
);
self::assertCount(1, $result);
self::assertArrayHasKey(self::EVALUATION_A_ID, $result);
self::assertCount(1, $result[self::EVALUATION_A_ID]);
self::assertSame($gradeOwnTenant, $result[self::EVALUATION_A_ID][0]);
}
#[Test]
public function findByEvaluationsExcludesGradesForUnrequestedEvaluations(): void
{
$gradeA = $this->createGrade(self::EVALUATION_A_ID, self::TENANT_ID, 14.0);
$gradeC = $this->createGrade(self::EVALUATION_C_ID, self::TENANT_ID, 10.0);
$this->repository->save($gradeA);
$this->repository->save($gradeC);
$result = $this->repository->findByEvaluations(
[EvaluationId::fromString(self::EVALUATION_A_ID)],
TenantId::fromString(self::TENANT_ID),
);
self::assertCount(1, $result);
self::assertArrayHasKey(self::EVALUATION_A_ID, $result);
self::assertArrayNotHasKey(self::EVALUATION_C_ID, $result);
}
private function createGrade(
string $evaluationId,
string $tenantId,
float $value,
): Grade {
return Grade::saisir(
tenantId: TenantId::fromString($tenantId),
evaluationId: EvaluationId::fromString($evaluationId),
studentId: UserId::fromString(self::STUDENT_ID),
value: new GradeValue($value),
status: GradeStatus::GRADED,
gradeScale: new GradeScale(20),
createdBy: UserId::fromString(self::TEACHER_ID),
now: new DateTimeImmutable('2026-03-26 10:00:00'),
);
}
}

View File

@@ -0,0 +1,114 @@
<?php
declare(strict_types=1);
namespace App\Tests\Unit\Scolarite\Infrastructure\Security;
use App\Administration\Domain\Model\User\Role;
use App\Administration\Domain\Model\User\UserId;
use App\Administration\Infrastructure\Security\SecurityUser;
use App\Scolarite\Infrastructure\Security\GradeParentVoter;
use App\Shared\Domain\Tenant\TenantId;
use PHPUnit\Framework\Attributes\DataProvider;
use PHPUnit\Framework\Attributes\Test;
use PHPUnit\Framework\TestCase;
use Symfony\Component\Security\Core\Authentication\Token\TokenInterface;
use Symfony\Component\Security\Core\Authorization\Voter\Voter;
use Symfony\Component\Security\Core\User\UserInterface;
final class GradeParentVoterTest extends TestCase
{
private const string TENANT_ID = '550e8400-e29b-41d4-a716-446655440002';
private GradeParentVoter $voter;
protected function setUp(): void
{
$this->voter = new GradeParentVoter();
}
#[Test]
public function itAbstainsForUnrelatedAttributes(): void
{
$token = $this->tokenWithSecurityUser(Role::PARENT->value);
$result = $this->voter->vote($token, null, ['SOME_OTHER_ATTRIBUTE']);
self::assertSame(Voter::ACCESS_ABSTAIN, $result);
}
#[Test]
public function itDeniesAccessToUnauthenticatedUsers(): void
{
$token = $this->createMock(TokenInterface::class);
$token->method('getUser')->willReturn(null);
$result = $this->voter->vote($token, null, [GradeParentVoter::VIEW]);
self::assertSame(Voter::ACCESS_DENIED, $result);
}
#[Test]
public function itDeniesAccessToNonSecurityUserInstances(): void
{
$user = $this->createMock(UserInterface::class);
$user->method('getRoles')->willReturn([Role::PARENT->value]);
$token = $this->createMock(TokenInterface::class);
$token->method('getUser')->willReturn($user);
$result = $this->voter->vote($token, null, [GradeParentVoter::VIEW]);
self::assertSame(Voter::ACCESS_DENIED, $result);
}
#[Test]
public function itGrantsViewToParent(): void
{
$token = $this->tokenWithSecurityUser(Role::PARENT->value);
$result = $this->voter->vote($token, null, [GradeParentVoter::VIEW]);
self::assertSame(Voter::ACCESS_GRANTED, $result);
}
#[Test]
#[DataProvider('nonParentRolesProvider')]
public function itDeniesViewToNonParentRoles(string $role): void
{
$token = $this->tokenWithSecurityUser($role);
$result = $this->voter->vote($token, null, [GradeParentVoter::VIEW]);
self::assertSame(Voter::ACCESS_DENIED, $result);
}
/** @return iterable<string, array{string}> */
public static function nonParentRolesProvider(): iterable
{
yield 'SUPER_ADMIN' => [Role::SUPER_ADMIN->value];
yield 'ADMIN' => [Role::ADMIN->value];
yield 'PROF' => [Role::PROF->value];
yield 'VIE_SCOLAIRE' => [Role::VIE_SCOLAIRE->value];
yield 'SECRETARIAT' => [Role::SECRETARIAT->value];
yield 'ELEVE' => [Role::ELEVE->value];
}
private function tokenWithSecurityUser(
string $role,
string $userId = '550e8400-e29b-41d4-a716-446655440001',
): TokenInterface {
$securityUser = new SecurityUser(
UserId::fromString($userId),
'test@example.com',
'hashed_password',
TenantId::fromString(self::TENANT_ID),
[$role],
);
$token = $this->createMock(TokenInterface::class);
$token->method('getUser')->willReturn($securityUser);
return $token;
}
}

View File

@@ -0,0 +1,98 @@
<?php
declare(strict_types=1);
namespace App\Tests\Unit\Scolarite\Infrastructure\Service;
use App\Scolarite\Infrastructure\Service\DatabaseParentGradeDelayReader;
use App\Shared\Domain\Tenant\TenantId;
use Doctrine\DBAL\Connection;
use PHPUnit\Framework\Attributes\Test;
use PHPUnit\Framework\TestCase;
final class DatabaseParentGradeDelayReaderTest extends TestCase
{
private const string TENANT_ID = '550e8400-e29b-41d4-a716-446655440001';
#[Test]
public function itReturnsConfiguredDelayWhenRowExists(): void
{
$connection = $this->createMock(Connection::class);
$connection
->method('fetchOne')
->willReturn('48');
$reader = new DatabaseParentGradeDelayReader($connection);
$result = $reader->delayHoursForTenant(TenantId::fromString(self::TENANT_ID));
self::assertSame(48, $result);
}
#[Test]
public function itReturnsDefault24HoursWhenNoRowFound(): void
{
$connection = $this->createMock(Connection::class);
$connection
->method('fetchOne')
->willReturn(false);
$reader = new DatabaseParentGradeDelayReader($connection);
$result = $reader->delayHoursForTenant(TenantId::fromString(self::TENANT_ID));
self::assertSame(24, $result);
}
#[Test]
public function itReturnsDefault24HoursWhenResultIsNonNumeric(): void
{
$connection = $this->createMock(Connection::class);
$connection
->method('fetchOne')
->willReturn('not-a-number');
$reader = new DatabaseParentGradeDelayReader($connection);
$result = $reader->delayHoursForTenant(TenantId::fromString(self::TENANT_ID));
self::assertSame(24, $result);
}
#[Test]
public function itPassesTenantIdToQuery(): void
{
$tenantId = TenantId::fromString(self::TENANT_ID);
$connection = $this->createMock(Connection::class);
$connection
->expects(self::once())
->method('fetchOne')
->with(
self::stringContains('tenant_id'),
self::equalTo(['tenant_id' => (string) $tenantId]),
)
->willReturn('12');
$reader = new DatabaseParentGradeDelayReader($connection);
$result = $reader->delayHoursForTenant($tenantId);
self::assertSame(12, $result);
}
#[Test]
public function itCastsNumericStringToInt(): void
{
$connection = $this->createMock(Connection::class);
$connection
->method('fetchOne')
->willReturn('0');
$reader = new DatabaseParentGradeDelayReader($connection);
$result = $reader->delayHoursForTenant(TenantId::fromString(self::TENANT_ID));
self::assertSame(0, $result);
}
}